Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue3438 d xdehumidifier merge fix #3799

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ within Buildings.Fluid.Humidifiers.BaseClasses;
block PerformanceCurveModifier
"Block for calculating modifier curves"

parameter Buildings.Fluid.Humidifiers.Data.Generic per
parameter Buildings.Fluid.Humidifiers.Data.DXDehumidifier.Generic per
"Data record"
annotation (Placement(transformation(extent={{22,64},{42,84}})));

Expand Down
3 changes: 2 additions & 1 deletion Buildings/Fluid/Humidifiers/DXDehumidifier.mo
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ model DXDehumidifier "DX dehumidifier"
parameter Boolean addPowerToMedium = true
"Transfer power and heat to the fluid medium";

parameter Buildings.Fluid.Humidifiers.Data.Generic per
parameter Buildings.Fluid.Humidifiers.Data.DXDehumidifier.Generic per
"Performance data"
annotation (choicesAllMatching=true,
Placement(transformation(extent={{60,80},{80,100}})));
Expand Down Expand Up @@ -116,6 +116,7 @@ model DXDehumidifier "DX dehumidifier"
Buildings.Fluid.Humidifiers.BaseClasses.PerformanceCurveModifier perCurMod(per=per)
"Block for calculating modifier curves"
annotation (Placement(transformation(extent={{-50,-110},{-30,-90}})));

protected
constant Modelica.Units.SI.SpecificEnthalpy h_fg= Buildings.Utilities.Psychrometrics.Constants.h_fg
"Latent heat of water vapor";
Expand Down
35 changes: 35 additions & 0 deletions Buildings/Fluid/Humidifiers/Data/DXDehumidifier/EnergyPlus.mo
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
within Buildings.Fluid.Humidifiers.Data.DXDehumidifier;
record EnergyPlus
"Example data record for DX dehumidifier model from EnergyPlus"

extends Buildings.Fluid.Humidifiers.Data.DXDehumidifier.Generic(watRem={-2.72487866408,
0.100711983591,-9.90538285E-04,0.050053043874,-2.03629282E-04,-3.41750531E-04},
eneFac={-2.38831907E+00,0.093047739452,-1.36970033E-03,0.066533716758,-3.43198063E-04,
-5.62490295E-04});

annotation (preferredView="info",
Documentation(info="<html>
<p>This is an example data record for the DX dehumidifier that uses parameters
from an EnergyPlus v23.1.0 Example model <code>SingleFamilyHouse_HP_Slab_Dehumidification.idf</code>.
</p>
</html>",
revisions="<html>
<ul>
<li>
June 20, 2023, by Xing Lu and Karthik Devaprasad:<br/>
First implementation.
</li>
</ul>
</html>"),
Icon(graphics={
Text(
extent={{-91,1},{-8,-54}},
textColor={0,0,255},
fontSize=16,
textString="watRem"),
Text(
extent={{2,-16},{94,-38}},
textColor={0,0,255},
textString="eneFac",
fontSize=16)}));
end EnergyPlus;
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
within Buildings.Fluid.Humidifiers.Data;
within Buildings.Fluid.Humidifiers.Data.DXDehumidifier;
record Generic
"Base data record for DX dehumidifier model"

Expand Down
11 changes: 11 additions & 0 deletions Buildings/Fluid/Humidifiers/Data/DXDehumidifier/package.mo
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
within Buildings.Fluid.Humidifiers.Data;
package DXDehumidifier
"Package with data record for DX dehumidifier"
extends Modelica.Icons.MaterialPropertiesPackage;

annotation (Documentation(info="<html>
<p>
This package contains data records for the zone air DX dehumidifier.
</p>
</html>"));
end DXDehumidifier;
2 changes: 2 additions & 0 deletions Buildings/Fluid/Humidifiers/Data/DXDehumidifier/package.order
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
EnergyPlus
Generic
5 changes: 3 additions & 2 deletions Buildings/Fluid/Humidifiers/Data/package.mo
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
within Buildings.Fluid.Humidifiers;
package Data "Package with data record for DX dehumidifier"
package Data
"Package with data records for classes in Humidifiers package"
extends Modelica.Icons.MaterialPropertiesPackage;

annotation (Documentation(info="<html>
<p>
This package contains a data record baseclass for the zone air DX dehumidifier.
This package contains data records for the classes in the Humidifiers package.
</p>
</html>"));
end Data;
2 changes: 1 addition & 1 deletion Buildings/Fluid/Humidifiers/Data/package.order
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Generic
DXDehumidifier
2 changes: 1 addition & 1 deletion Buildings/Fluid/Humidifiers/Validation/DXDehumidifier.mo
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ model DXDehumidifier "Validation model for DX dehumidifier"
parameter Modelica.Units.SI.Time tStepAve = 3600
"Time-step used to average out Modelica results for comparison with EPlus results";

parameter Buildings.Fluid.Humidifiers.Validation.Data.DXDehumidifier per
parameter Buildings.Fluid.Humidifiers.Data.DXDehumidifier.EnergyPlus per
"Zone air DX dehumidifier curve"
annotation (Placement(transformation(extent={{-40,66},{-20,86}})));

Expand Down
33 changes: 0 additions & 33 deletions Buildings/Fluid/Humidifiers/Validation/Data/DXDehumidifier.mo

This file was deleted.

11 changes: 0 additions & 11 deletions Buildings/Fluid/Humidifiers/Validation/Data/package.mo

This file was deleted.

1 change: 0 additions & 1 deletion Buildings/Fluid/Humidifiers/Validation/Data/package.order

This file was deleted.

1 change: 0 additions & 1 deletion Buildings/Fluid/Humidifiers/Validation/package.order
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,3 @@ SprayAirWasher_X
SprayAirWasher_X_dynamic
SteamHumidifier_X
SteamHumidifier_X_dynamic
Data