Issue2180 boiler plant main controller oct 2021 #3168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler_oct_2021 Issue2180 boiler plant main controller oct 2021
…ntroller_oct_2021 Issue2180 boiler plant main controller oct 2021
|
@JayHuLBL : Hi Jianjun! This PR is ready for review. It should resolve the additional comments on #2700. Thanks! |
|
@karthikeyad-pnnl I will merge this PR as it has addressed the formatting and syntax issues. However, when running unit test, I see the results difference. This could be due to the dymola version changes. We could update the results in the development branch. |
JayHuLBL
merged commit fe2a983
into
lbl-srg:issue2180_BoilerPlant_MainController_oct_2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.