-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templates • CHW plant #3167
Draft
AntoineGautier
wants to merge
1,628
commits into
master
Choose a base branch
from
issue1374_template_CHW_final
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Templates • CHW plant #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue1374_templates
- All validation models simulate with OCT.
- Per G36 4.10.7 these sensors are always required (R).
- WSE requires headered CW pumps, thus inlConChi.have_comLeg=true.
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
August 31, 2023 13:03
f16c69a
to
2e56df8
Compare
AntoineGautier
force-pushed
the
issue1374_template_CHW_final
branch
from
August 31, 2023 13:13
2e56df8
to
737165e
Compare
There is an ambiguity in G36 for series chillers. CH CHW isolation valves are also referred to as CH CHW bypass valves. We consider them as isolation valves. We let users select between modulating and 2-position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shall NOT be merged before #2299 is merged.
This is a draft PR to test CI testing with
test-templates-optimica
andtest-templates-dymola
.TODO before merging:
issue2293_chiller_plant_seq
is merged into the master, replaceBuildings.Templates.ChilledWaterPlants.Components.Controls.Controller_debug
with the actual controller.Buildings/Resources/Scripts/travis/templates/ChilledWaterPlants.py
and.travis.yml
.issue1374_template_CHW_final
uses port placement parameterization for the WSE and CT components.Note that the template models are currently not supported by Dymola due to a bug in handling arrays of record.
Tickets #SR01004314-01 #SR01022035-01 and #SR00955379-01 are in status "Wait for Correction Delivery" or "R&D Handling" at DS.
issue1374_template_CHW_final
is not kept in sync with the master since early 2023 due to the issue described below.