Code

Issue2886 fan coil model#3124

Code

Open

SenHuang19 wants to merge 125 commits intolbl-srg:issue2886_fanCoilModellbl-srg/modelica-buildings:issue2886_fanCoilModelfrom SenHuang19:issue2886_fanCoilModelSenHuang19/modelica-buildings:issue2886_fanCoilModelCopy head branch name to clipboard

+535,771

Commits

Commits on Jun 1, 2022

• Added files from development branch

  karthikeyad-pnnl

  committed
  9e9ab61

  Copy full SHA for 9e9ab61

• Updated package order files

  karthikeyad-pnnl

  committed
  f18e0ff

  Copy full SHA for f18e0ff

• Updated class names with global paths and latest CDL blocks

  karthikeyad-pnnl

  committed
  6e4367b

  Copy full SHA for 6e4367b

• Updated branch with data files from development branch

  karthikeyad-pnnl

  committed
  727e313

  Copy full SHA for 727e313

• Changed dat file to use git lfs

  karthikeyad-pnnl

  committed
  0bdfe3c

  Copy full SHA for 0bdfe3c

• Updated python script to include additional output variable in dat file

  karthikeyad-pnnl

  committed
  4aa215c

  Copy full SHA for 4aa215c

• Updated dat file with new output variable

  karthikeyad-pnnl

  committed
  3699260

  Copy full SHA for 3699260

• Added validation script for simulating and plotting

  karthikeyad-pnnl

  committed
  41fb676

  Copy full SHA for 41fb676

Commits on Jun 3, 2022

• Merge pull request #1 from lbl-srg/master

  Show description for e01cbf7
  SenHuang19

  authored
  e01cbf7

  Copy full SHA for e01cbf7

Commits on Jun 10, 2022

• Added additional output variables to idf and csv_to_mos.py

  karthikeyad-pnnl

  committed
  6bb5255

  Copy full SHA for 6bb5255

• Added additional output variables to FanCoil.dat

  karthikeyad-pnnl

  committed
  ba36a93

  Copy full SHA for ba36a93

Commits on Jun 13, 2022

• Merge branch 'upstream_master' into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  3c86a04

  Copy full SHA for 3c86a04

Commits on Jun 14, 2022

• Added new idf files and updated bash and python scripts to run them and process their results

  karthikeyad-pnnl

  committed
  4402c76

  Copy full SHA for 4402c76

• Added dat file for new idf. Modified python script

  karthikeyad-pnnl

  committed
  71397ea

  Copy full SHA for 71397ea

Commits on Jun 15, 2022

• Updated control module name

  karthikeyad-pnnl

  committed
  52078de

  Copy full SHA for 52078de

• Added new class to Data package to introduce new calculations for cooling coil UA

  karthikeyad-pnnl

  committed
  e97bfb4

  Copy full SHA for e97bfb4

• Added validation file that uses SPAWN thermal zone

  karthikeyad-pnnl

  committed
  3ed0159

  Copy full SHA for 3ed0159

• Replaced fan type with model that uses mass flowrate input

  karthikeyad-pnnl

  committed
  cc890b5

  Copy full SHA for cc890b5

• Added calculations for cumulative energy consumption. Replaced sizing record with one that has updated UA calculations. Changed damper opening and zone mixing volume pressure to closely mirror EPlu…

  Show description for 6974747
  karthikeyad-pnnl

  committed
  6974747

  Copy full SHA for 6974747

• Changed simulation time to cooling season

  karthikeyad-pnnl

  committed
  4691780

  Copy full SHA for 4691780

• Added new plotting script to study cooling mode operation

  karthikeyad-pnnl

  committed
  adf0a1a

  Copy full SHA for adf0a1a

Commits on Jun 23, 2022

• Added output variable for sensible cooling rate to data file

  karthikeyad-pnnl

  committed
  e6943df

  Copy full SHA for e6943df

• Added new output variable to .dat file

  karthikeyad-pnnl

  committed
  0eb4cac

  Copy full SHA for 0eb4cac

Commits on Jun 24, 2022

• Updated files

  karthikeyad-pnnl

  committed
  89a6d61

  Copy full SHA for 89a6d61

Commits on Jun 25, 2022

• Added output variable for humidity ratio to python script

  karthikeyad-pnnl

  committed
  8de271b

  Copy full SHA for 8de271b

• Added new output variable to dat file

  karthikeyad-pnnl

  committed
  a15b56e

  Copy full SHA for a15b56e

Commits on Jun 27, 2022

• Added new class for cooling coil UA calculations. Changed current model to use X_input for zone volume. Added new model with no X_input for zone volume. Updated mos scripts for both files

  karthikeyad-pnnl

  committed
  064f32b

  Copy full SHA for 064f32b

Commits on Jun 29, 2022

• Upadted models to use HHW and CHW sources with mass flowrate input

  karthikeyad-pnnl

  committed
  5ef407f

  Copy full SHA for 5ef407f

• Added file for fan curve calculations

  karthikeyad-pnnl

  committed
  a375198

  Copy full SHA for a375198

• Added fan curves to fan model. Added fan power plots to .mos scripts

  karthikeyad-pnnl

  committed
  489afaa

  Copy full SHA for 489afaa

Commits on Jul 1, 2022

• Added additional correction factor to UA calculations

  karthikeyad-pnnl

  committed
  6f2dfa2

  Copy full SHA for 6f2dfa2

Commits on Jul 5, 2022

• Updated package structure and model class names

  karthikeyad-pnnl

  committed
  7584c2f

  Copy full SHA for 7584c2f

• Merge remote-tracking branch 'Sen_upstream/issue2886_fanCoilModel' into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  a03b61f

  Copy full SHA for a03b61f

• Removed unused sizing calculations

  karthikeyad-pnnl

  committed
  a647524

  Copy full SHA for a647524

• Removed unused data resources

  karthikeyad-pnnl

  committed
  8d79675

  Copy full SHA for 8d79675

• Upadetd package order file

  karthikeyad-pnnl

  committed
  7473e8c

  Copy full SHA for 7473e8c

• Merge pull request #2 from karthikeyad-pnnl/issue2886_fanCoilModel

  Show description for 78b3cb7
  SenHuang19

  authored
  78b3cb7

  Copy full SHA for 78b3cb7

• fix path issues in the example

  

  Huang

  committed
  92a1b16

  Copy full SHA for 92a1b16

• Moved FCU fan performance curve to zone equipment package

  karthikeyad-pnnl

  committed
  15b9a9a

  Copy full SHA for 15b9a9a

Commits on Jul 7, 2022

• fixed the warning and errors in the validation example

  

  Huang

  committed
  d557b25

  Copy full SHA for d557b25

• Updated propagation parameter for fan performance curve

  karthikeyad-pnnl

  committed
  0cd2c0c

  Copy full SHA for 0cd2c0c

• Merge remote-tracking branch 'Sen_upstream/issue2886_fanCoilModel' into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  82def11

  Copy full SHA for 82def11

Commits on Jul 15, 2022

• Updated parameters for heating mode validation

  karthikeyad-pnnl

  committed
  d9ab967

  Copy full SHA for d9ab967

• Updated fan curve to get energy results closer to EPlus

  karthikeyad-pnnl

  committed
  7a7a21c

  Copy full SHA for 7a7a21c

Commits on Jul 16, 2022

• Added output variables for system node pressure at fan inlet and outlet

  karthikeyad-pnnl

  committed
  2679c2a

  Copy full SHA for 2679c2a

• Updated dat file

  karthikeyad-pnnl

  committed
  af7b3bd

  Copy full SHA for af7b3bd

Commits on Jul 19, 2022

• Added data for fan pressure rise to data table

  karthikeyad-pnnl

  committed
  6cb3501

  Copy full SHA for 6cb3501

Commits on Jul 20, 2022

• Updated package structure and removed redundant files and models

  karthikeyad-pnnl

  committed
  583b684

  Copy full SHA for 583b684

• Updated package structure. Added control module for constant fan speed - variable flowrate capacity control

  karthikeyad-pnnl

  committed
  58139e9

  Copy full SHA for 58139e9

Commits on Jul 21, 2022

• Added control module for multispeed fan control

  karthikeyad-pnnl

  committed
  ebf748a

  Copy full SHA for ebf748a

• Updated package order files

  karthikeyad-pnnl

  committed
  17572da

  Copy full SHA for 17572da

• Added open loop validation models for both heating and cooling mode operation

  karthikeyad-pnnl

  committed
  2cc9c98

  Copy full SHA for 2cc9c98

• Updated package order

  karthikeyad-pnnl

  committed
  fa7b07c

  Copy full SHA for fa7b07c

Commits on Jul 22, 2022

• Updated sizing file with correct value of outlet air temperature

  karthikeyad-pnnl

  committed
  87ca7b6

  Copy full SHA for 87ca7b6

Commits on Jul 26, 2022

• Changed model names for control modules

  karthikeyad-pnnl

  committed
  063c90e

  Copy full SHA for 063c90e

• Updated correction factor for cooling coil UA

  karthikeyad-pnnl

  committed
  0e2c5cd

  Copy full SHA for 0e2c5cd

Commits on Aug 4, 2022

• Updated formatting and documentation

  karthikeyad-pnnl

  committed
  500ddfb

  Copy full SHA for 500ddfb

• Removed redundant parameter setting

  karthikeyad-pnnl

  committed
  4a82f17

  Copy full SHA for 4a82f17

Commits on Aug 8, 2022

• Updated documentation

  karthikeyad-pnnl

  committed
  82742a1

  Copy full SHA for 82742a1

Commits on Aug 9, 2022

• Updated cooling mode validation model

  karthikeyad-pnnl

  committed
  d270dd6

  Copy full SHA for d270dd6

• Updated documentation for cooling mode validation model

  karthikeyad-pnnl

  committed
  2447937

  Copy full SHA for 2447937

• Updated documentation sections

  karthikeyad-pnnl

  committed
  2eb534e

  Copy full SHA for 2eb534e

• Removed redundant instances and plots

  karthikeyad-pnnl

  committed
  92b2ecf

  Copy full SHA for 92b2ecf

Commits on Aug 11, 2022

• Updated documentation and models

  karthikeyad-pnnl

  committed
  32edf6c

  Copy full SHA for 32edf6c

• Updated validation script

  karthikeyad-pnnl

  committed
  c5fe2f9

  Copy full SHA for c5fe2f9

• Added svg files

  karthikeyad-pnnl

  committed
  8d6a19f

  Copy full SHA for 8d6a19f

Commits on Aug 12, 2022

• Upadted control modules

  karthikeyad-pnnl

  committed
  e4d581b

  Copy full SHA for e4d581b

Commits on Aug 13, 2022

• Updated models for multispeed fan controller

  karthikeyad-pnnl

  committed
  565f668

  Copy full SHA for 565f668

Commits on Aug 16, 2022

• Added documentation to control modules

  karthikeyad-pnnl

  committed
  a50a2ee

  Copy full SHA for a50a2ee

Commits on Aug 19, 2022

• Updated validation models and associated documentation

  karthikeyad-pnnl

  committed
  8561746

  Copy full SHA for 8561746

• Updated connection statement

  karthikeyad-pnnl

  committed
  922668b

  Copy full SHA for 922668b

Commits on Sep 2, 2022

• Updated comments

  karthikeyad-pnnl

  committed
  5cab0ab

  Copy full SHA for 5cab0ab

• Updated data types for parameters

  karthikeyad-pnnl

  committed
  5812d60

  Copy full SHA for 5812d60

• Updated validation model names

  karthikeyad-pnnl

  committed
  7009ea2

  Copy full SHA for 7009ea2

• Renamed control modules

  karthikeyad-pnnl

  committed
  a6fdeac

  Copy full SHA for a6fdeac

Commits on Sep 6, 2022

• Updated files based on comments

  karthikeyad-pnnl

  committed
  a1bcc38

  Copy full SHA for a1bcc38

• Updated documentation and formatting

  karthikeyad-pnnl

  committed
  38efb5c

  Copy full SHA for 38efb5c

• Updated validation script and removed unused expression blocks

  karthikeyad-pnnl

  committed
  45611e2

  Copy full SHA for 45611e2

• Renamed system model and updated documentation for validation files

  karthikeyad-pnnl

  committed
  b95f262

  Copy full SHA for b95f262

Commits on Sep 8, 2022

• Updated class names for validation records

  karthikeyad-pnnl

  committed
  41e39bf

  Copy full SHA for 41e39bf

• Updated type class

  karthikeyad-pnnl

  committed
  b7319a7

  Copy full SHA for b7319a7

• Removed folder that is not part of upstream repo

  karthikeyad-pnnl

  committed
  0e817f1

  Copy full SHA for 0e817f1

• Updated validation script

  karthikeyad-pnnl

  committed
  f773839

  Copy full SHA for f773839

Commits on Sep 9, 2022

• Updated instance names for uniformity

  karthikeyad-pnnl

  committed
  d781f2c

  Copy full SHA for d781f2c

• Changed calculated parameter to protected

  karthikeyad-pnnl

  committed
  f4321da

  Copy full SHA for f4321da

• Updated connections and removed unnecessary value

  karthikeyad-pnnl

  committed
  b1c79de

  Copy full SHA for b1c79de

• Updated instance name

  karthikeyad-pnnl

  committed
  27bd00c

  Copy full SHA for 27bd00c

• Merge pull request #3 from karthikeyad-pnnl/issue2886_fanCoilModel

  Show description for 512b4f0
  SenHuang19

  authored
  512b4f0

  Copy full SHA for 512b4f0

Commits on Sep 11, 2022

• clean up

  

  Huang

  committed
  ea42113

  Copy full SHA for ea42113

Commits on Sep 13, 2022

• Merge pull request lbl-srg#35 from SenHuang19/issue2886_fanCoilModel

  Show description for fbc46ce
  karthikeyad-pnnl

  authored
  fbc46ce

  Copy full SHA for fbc46ce

• Upadted icon layer for FCU model. Upadted graphical layer for validation models

  karthikeyad-pnnl

  committed
  6517b72

  Copy full SHA for 6517b72

• Updated medium name for chilled water to MediumCW. Fixed simulation issues with validation models due to updates to instance names.

  karthikeyad-pnnl

  committed
  a8ffab9

  Copy full SHA for a8ffab9

Commits on Sep 14, 2022

• Updated documentation. Changed instance names and medium for CHW components

  karthikeyad-pnnl

  committed
  cf3dd8e

  Copy full SHA for cf3dd8e

Commits on Sep 19, 2022

• Updated control logic for variable fan-constant flow controller

  karthikeyad-pnnl

  committed
  81894c4

  Copy full SHA for 81894c4

• Added output interfaces for measured fan speed and supply temperature

  karthikeyad-pnnl

  committed
  ccbbeda

  Copy full SHA for ccbbeda

• Added example package with model demonstrating use-case

  karthikeyad-pnnl

  committed
  2cd8a6a

  Copy full SHA for 2cd8a6a

• Updated documentation and formatting

  karthikeyad-pnnl

  committed
  5547a3f

  Copy full SHA for 5547a3f

• Updated documentation

  karthikeyad-pnnl

  committed
  1f7e3ff

  Copy full SHA for 1f7e3ff

• Added tolerance value to validation models

  karthikeyad-pnnl

  committed
  577b499

  Copy full SHA for 577b499

• Fixed validation script

  karthikeyad-pnnl

  committed
  53d817d

  Copy full SHA for 53d817d

• Changed models to fix errors found in unit test

  karthikeyad-pnnl

  committed
  9d0b579

  Copy full SHA for 9d0b579

• Fixed parameter definition in sizing data file

  karthikeyad-pnnl

  committed
  047a398

  Copy full SHA for 047a398

• Fixed parameter setting

  karthikeyad-pnnl

  committed
  b755dba

  Copy full SHA for b755dba

• Fixed parameter data type in example package

  karthikeyad-pnnl

  committed
  c350894

  Copy full SHA for c350894

• Added start vlue to outdoor air source medium

  karthikeyad-pnnl

  committed
  4d8787c

  Copy full SHA for 4d8787c

Commits on Sep 20, 2022

• Parametrized controls modifications

  karthikeyad-pnnl

  committed
  5dca36f

  Copy full SHA for 5dca36f

• Added unit test results to the repo

  karthikeyad-pnnl

  committed
  8f93093

  Copy full SHA for 8f93093

• Merge branch 'issue2886_fanCoilModel' of github.com:karthikeyad-pnnl/modelica-buildings into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  6015c41

  Copy full SHA for 6015c41

• Removed illegal Modelica modifier

  karthikeyad-pnnl

  committed
  ad5a479

  Copy full SHA for ad5a479

Commits on Sep 26, 2022

• Merge pull request #4 from karthikeyad-pnnl/issue2886_fanCoilModel

  Show description for 575e74a
  SenHuang19

  authored
  575e74a

  Copy full SHA for 575e74a

Commits on Sep 27, 2022

• Updated all control modules to use an input signal for occupancy

  karthikeyad-pnnl

  committed
  7b8c0ca

  Copy full SHA for 7b8c0ca

Commits on Sep 28, 2022

• minor clean up and a bug fix

  

  Huang

  committed
  6cf5a35

  Copy full SHA for 6cf5a35

Commits on Sep 29, 2022

• Merge branch 'issue2886_fanCoilModel' of github.com:SenHuang19/modelica-buildings into SenHuang19-issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  6f45446

  Copy full SHA for 6f45446

• Merge branch 'SenHuang19-issue2886_fanCoilModel' into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  02886e1

  Copy full SHA for 02886e1

• fix html issue

  

  Huang

  committed
  09d3b97

  Copy full SHA for 09d3b97

• Updated formatting

  karthikeyad-pnnl

  committed
  98ada73

  Copy full SHA for 98ada73

• minor changes to the model and update the reference dataset

  

  Huang

  committed
  9e7779f

  Copy full SHA for 9e7779f

• Updated formatting and added documentation

  karthikeyad-pnnl

  committed
  2db15c8

  Copy full SHA for 2db15c8

• clean up

  

  Huang

  committed
  fbde96a

  Copy full SHA for fbde96a

Commits on Oct 3, 2022

• Merge branch 'issue2886_fanCoilModel' of github.com:SenHuang19/modelica-buildings into SenHuang19-issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  7d346d0

  Copy full SHA for 7d346d0

• Merge branch 'SenHuang19-issue2886_fanCoilModel' into issue2886_fanCoilModel

  karthikeyad-pnnl

  committed
  bef21a0

  Copy full SHA for bef21a0

• Added unit test results

  karthikeyad-pnnl

  committed
  dfbc265

  Copy full SHA for dfbc265

• Updated formatting

  karthikeyad-pnnl

  committed
  0a5b001

  Copy full SHA for 0a5b001

Commits on Oct 11, 2022

• Merge pull request #5 from karthikeyad-pnnl/issue2886_fanCoilModel

  Show description for 0207625
  SenHuang19

  authored
  0207625

  Copy full SHA for 0207625

• update the baseline data; clean up the doc and fix the breaking link

  

  Huang

  committed
  5b7e836

  Copy full SHA for 5b7e836