Skip to content

Commit

Permalink
updated references and comments, #2293 [ci skip]
Browse files Browse the repository at this point in the history
  • Loading branch information
JayHuLBL committed May 19, 2021
1 parent dbfe293 commit bc425ed
Show file tree
Hide file tree
Showing 19 changed files with 49 additions and 46 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ block Controller "Condenser water pump controller"
annotation (Placement(transformation(extent={{120,-20},{160,20}}),
iconTransformation(extent={{100,-50},{140,-10}})));
Buildings.Controls.OBC.CDL.Interfaces.BooleanOutput yPumSpeChe
"Flag to indicate if pump speed achieve setpoint"
"Flag to indicate if pump speed achieves setpoint"
annotation (Placement(transformation(extent={{120,-100},{160,-60}}),
iconTransformation(extent={{100,-110},{140,-70}})));
Buildings.Controls.OBC.CDL.Continuous.AddParameter addPar(
Expand Down Expand Up @@ -244,7 +244,7 @@ annotation (
<p>
Block that generates control signals for condenser water pumps control,
according to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft on March 2020),
Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.9 Condenser water pumps.
</p>
<p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ block EnableLead_dedicated
"Threshold to check lead chiller OFF time";

Buildings.Controls.OBC.CDL.Interfaces.BooleanInput uLeaChiEna
"Lead chiller enabling status"
"Lead chiller commanded on status"
annotation (Placement(transformation(extent={{-140,50},{-100,90}}),
iconTransformation(extent={{-140,60},{-100,100}})));
Buildings.Controls.OBC.CDL.Interfaces.BooleanInput uLeaChiSta
Expand All @@ -35,9 +35,10 @@ protected
annotation (Placement(transformation(extent={{60,60},{80,80}})));
Buildings.Controls.OBC.CDL.Logical.Timer tim(
final t=offTimThr)
"Check if the chiller has been OFF for more than threshold"
"Check if the chiller has been proven off for more than threshold time"
annotation (Placement(transformation(extent={{-40,-30},{-20,-10}})));
Buildings.Controls.OBC.CDL.Logical.Not not3 "Logical not"
Buildings.Controls.OBC.CDL.Logical.Not not3
"Check if the lead chiller is disabled"
annotation (Placement(transformation(extent={{-60,30},{-40,50}})));
Buildings.Controls.OBC.CDL.Logical.And and2 "Logical and"
annotation (Placement(transformation(extent={{0,30},{20,50}})));
Expand Down Expand Up @@ -108,14 +109,14 @@ annotation (
Block that enable and disable lead condenser water pump, for plants
with dedicated condenser water pumps,
according to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft on March 2020),
Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.9 Condenser water pumps, part 5.2.9.4.
</p>
<p>
The lead condenser water pump should be enabled when lead chiller is commanded
to run (<code>uLeaChiEna</code> = true). It should be disabled when the lead
chiller is disabled and either the lead chiller has been proven off
(<code>uLeaChiSta</code> = false) for <code>offTimThr</code>, i.e. 3 minutes or
(<code>uLeaChiSta</code> = false) for <code>offTimThr</code>, i.e. 3 minutes, or
is not requesting condenser water flow (<code>uLeaConWatReq</code> = false).
</p>
</html>", revisions="<html>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ block EnableLead_headered
parameter Integer nChi=2 "Total number of chiller";

Buildings.Controls.OBC.CDL.Interfaces.BooleanInput uWseConIsoVal if
have_WSE
"WSE condenser water isolation valve status"
have_WSE "WSE condenser water isolation valve commanded status"
annotation (Placement(transformation(extent={{-140,-40},{-100,0}}),
iconTransformation(extent={{-140,-60},{-100,-20}})));
Buildings.Controls.OBC.CDL.Interfaces.BooleanInput uChiConIsoVal[nChi]
"Chiller condenser water isolation valve status"
"Chiller condenser water isolation valve commanded status"
annotation (Placement(transformation(extent={{-140,0},{-100,40}}),
iconTransformation(extent={{-140,20},{-100,60}})));
Buildings.Controls.OBC.CDL.Interfaces.BooleanOutput yLea "Lead pump status"
Expand Down Expand Up @@ -94,7 +93,7 @@ annotation (
Block that enable and disable lead condenser water pump, for plants
with headered condenser water pumps,
according to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft on March 2020),
Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.9 Condenser water pumps, part 5.2.9.2-3.
</p>
<ol>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ block Speed
parameter Boolean have_WSE = true
"Flag to indicate if the plant has water side economizer";
parameter Integer totSta = 6
"Total number of stages, including the stages with a WSE, if applicable";
"Total number of stages, including stage zero and the stages with a WSE, if applicable";
parameter Real staVec[totSta] = {0, 0.5, 1, 1.5, 2, 2.5}
"Chiller stage vector, element value like x.5 means chiller stage x plus WSE";
parameter Real desConWatPumSpe[totSta] = {0, 0.5, 0.75, 0.6, 0.75, 0.9}
Expand Down Expand Up @@ -77,7 +77,8 @@ protected
Buildings.Controls.OBC.CDL.Integers.MultiSum mulSumInt(
final nin=totSta) "Current stage index"
annotation (Placement(transformation(extent={{-60,-10},{-40,10}})));
Buildings.Controls.OBC.CDL.Continuous.Sources.Constant con4(final k=0) if not have_WSE
Buildings.Controls.OBC.CDL.Continuous.Sources.Constant con4(
final k=0) if not have_WSE
"Constant zero"
annotation (Placement(transformation(extent={{-120,-10},{-100,10}})));

Expand Down Expand Up @@ -160,7 +161,7 @@ annotation (
Block that outputs number of operating condenser water pumps and design pump speed
for current stage,
according to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft on March 2020),
Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.9 Condenser water pumps, part 5.2.9.6. This sequence is for plants
have variable speed condenser water pumps.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ Documentation(info="<html>
<p>
Block that output chilled water plant reset <code>yChiWatPlaRes</code> according
to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft 6 on July 25, 2019), section 5.2.5.2.
Central Plants and Hydronic Systems (Draft March 23, 2020), section 5.2.5.2.
</p>
<p>
Following implementation is for plants with primary-only and primary-secondary
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ block ChilledWaterSupply
"Maximum chilled water pump differential static pressure";
parameter Modelica.SIunits.ThermodynamicTemperature TChiWatSupMin(
displayUnit="K")
"Minimum chilled water supply temperature";
"Minimum chilled water supply temperature. This is the lowest minimum chilled water supply temperature of chillers in the plant";
parameter Modelica.SIunits.ThermodynamicTemperature TChiWatSupMax(
final min=TChiWatSupMin,
displayUnit="K") = 288.706
Expand Down Expand Up @@ -205,7 +205,7 @@ primary-secondary systems serving differential pressure controlled pumps.
The outputs include supply temperature setpoint <code>TChiWatSupSet</code>
and pump differential pressure setpoint <code>dpChiWatPumSet</code>, according
to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft 6 on July 25, 2019), section 5.2.5.2.
Central Plants and Hydronic Systems (Draft March 23, 2020), section 5.2.5.2.
</p>
<p>
Chilled water supply temperature setpoint <code>TChiWatSupSet</code> and pump
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ water-cooled primary-only parallel chiller plants with headered chilled water pu
and headered condenser water pumps, or air-cooled primary-only parallel chiller
plants with headered chilled water pumps.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version, March 2020),
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.17, which specifies the step-by-step control of
devices during chiller staging down process.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ block CHWIsoVal "Sequence of enable or disable chilled water isolation valve"

Buildings.Controls.OBC.CDL.Interfaces.IntegerInput nexChaChi
"Index of next chiller that should change status"
annotation (Placement(transformation(extent={{-200,-10},{-160,30}}),
annotation (Placement(transformation(extent={{-200,-20},{-160,20}}),
iconTransformation(extent={{-140,60},{-100,100}})));
Buildings.Controls.OBC.CDL.Interfaces.RealInput uChiWatIsoVal[nChi](
final unit=fill("1", nChi),
Expand Down Expand Up @@ -90,13 +90,13 @@ protected
Buildings.Controls.OBC.CDL.Logical.Switch swi1[nChi] "Logical switch"
annotation (Placement(transformation(extent={{60,-70},{80,-50}})));
Buildings.Controls.OBC.CDL.Logical.Switch swi2[nChi] "Logical switch"
annotation (Placement(transformation(extent={{60,0},{80,20}})));
annotation (Placement(transformation(extent={{60,-10},{80,10}})));
Buildings.Controls.OBC.CDL.Integers.Equal intEqu[nChi]
"Check next enabling isolation valve"
annotation (Placement(transformation(extent={{-20,0},{0,20}})));
annotation (Placement(transformation(extent={{-20,-10},{0,10}})));
Buildings.Controls.OBC.CDL.Routing.IntegerReplicator intRep(final nout=nChi)
"Replicate integer input"
annotation (Placement(transformation(extent={{-80,0},{-60,20}})));
annotation (Placement(transformation(extent={{-80,-10},{-60,10}})));
Buildings.Controls.OBC.CDL.Routing.RealReplicator reaRep(final nout=nChi)
"Replicate real input"
annotation (Placement(transformation(extent={{80,70},{100,90}})));
Expand Down Expand Up @@ -126,7 +126,7 @@ protected
annotation (Placement(transformation(extent={{140,130},{160,150}})));
Buildings.Controls.OBC.CDL.Integers.Sources.Constant conInt[nChi](
final k=chiInd) "Chiller index array"
annotation (Placement(transformation(extent={{-80,-30},{-60,-10}})));
annotation (Placement(transformation(extent={{-80,-40},{-60,-20}})));

equation
connect(uChiWatIsoVal, triSam.u)
Expand Down Expand Up @@ -188,24 +188,24 @@ equation
annotation (Line(points={{-180,-100},{-140,-100},{-140,-52},{58,-52}},
color={0,0,127}));
connect(swi2.y, swi.u1)
annotation (Line(points={{82,10},{100,10},{100,-32},{118,-32}},
annotation (Line(points={{82,0},{100,0},{100,-32},{118,-32}},
color={0,0,127}));
connect(nexChaChi, intRep.u)
annotation (Line(points={{-180,10},{-82,10}}, color={255,127,0}));
annotation (Line(points={{-180,0},{-82,0}}, color={255,127,0}));
connect(intRep.y, intEqu.u1)
annotation (Line(points={{-58,10},{-22,10}}, color={255,127,0}));
annotation (Line(points={{-58,0},{-22,0}}, color={255,127,0}));
connect(intEqu.y, swi2.u2)
annotation (Line(points={{2,10},{58,10}}, color={255,0,255}));
annotation (Line(points={{2,0},{58,0}}, color={255,0,255}));
connect(lin1.y, reaRep.u)
annotation (Line(points={{62,80},{78,80}}, color={0,0,127}));
connect(lat.y, tim.u)
annotation (Line(points={{42,-170},{50,-170},{50,-220},{-120,-220},
{-120,80},{-102,80}}, color={255,0,255}));
connect(reaRep.y, swi2.u1)
annotation (Line(points={{102,80},{120,80},{120,50},{40,50},{40,18},{58,18}},
annotation (Line(points={{102,80},{120,80},{120,50},{40,50},{40,8},{58,8}},
color={0,0,127}));
connect(triSam.y, swi2.u3)
annotation (Line(points={{-58,-100},{40,-100},{40,2},{58,2}},
annotation (Line(points={{-58,-100},{40,-100},{40,-8},{58,-8}},
color={0,0,127}));
connect(uChiWatIsoVal, hys4.u)
annotation (Line(points={{-180,-100},{-140,-100},{-140,160},{-122,160}},
Expand Down Expand Up @@ -241,7 +241,7 @@ equation
connect(or2.y, mulAnd1.u)
annotation (Line(points={{62,220},{78,220}}, color={255,0,255}));
connect(conInt.y, intEqu.u2)
annotation (Line(points={{-58,-20},{-40,-20},{-40,2},{-22,2}},
annotation (Line(points={{-58,-30},{-40,-30},{-40,-8},{-22,-8}},
color={255,127,0}));
connect(uUpsDevSta, and5.u2)
annotation (Line(points={{-180,-140},{-130,-140},{-130,140},{138,140}},
Expand Down Expand Up @@ -324,7 +324,7 @@ Block updates chiller chilled water isolation valve enabling-disabling status wh
there is stage change command (<code>chaPro=true</code>). It will also generate
status to indicate if the valve reset process has finished.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version, March 2020),
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.16, item 5 and section 5.2.4.17, item 3, which specifies when
and how the isolation valve should be controlled when it is in stage changing process.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,7 @@ Documentation(info="<html>
<p>
Block that controlles chiller when there is staging down command <code>uStaDow=true</code>.
This implementation is based on ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft version, March 2020), section 5.2.4.17,
Central Plants and Hydronic Systems (Draft on March 23, 2020), section 5.2.4.17,
item 1.e and f. These two sections specify how to start the smaller chiller and shut
off larger chiller when the stage change requires large chiller off and small chill on.
In other stage change, when it does not require chiller on/off, the chiller will then
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ block DownStart "Sequence for starting stage-down process"
annotation (Placement(transformation(extent={{-200,30},{-160,70}}),
iconTransformation(extent={{-140,-20},{-100,20}})));
Buildings.Controls.OBC.CDL.Interfaces.BooleanInput uOnOff
"True: if the stage change require one chiller to be enabled while another is disabled"
"True: if the stage change require enabling one chiller and disable another one"
annotation (Placement(transformation(extent={{-200,0},{-160,40}}),
iconTransformation(extent={{-140,-40},{-100,0}})));
Buildings.Controls.OBC.CDL.Interfaces.IntegerInput nexEnaChi
Expand Down Expand Up @@ -505,7 +505,7 @@ Documentation(info="<html>
<p>
Block that controls devices at the first step of chiller staging down process.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version, March 2020),
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.17, item 1 and 2. The sections specifies the first step of
staging down process.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ Documentation(info="<html>
Block that controlles chiller when there is staging up command <code>uStaUp=true</code>.
This implementation is based on ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft version, March 2020), section 5.2.4.16,
Central Plants and Hydronic Systems (Draft on March 23, 2020), section 5.2.4.16,
item 6 and item 7.a. These sections specify when the next chiller should be enabled
and when the running smaller chiller should be diabled.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,7 @@ Block that generates chiller head pressure control enabling status array when
there is stage change command (<code>chaPro=true</code>). It also generates status
to indicate if the head pressure control status change process has finished.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version,
March 2020):
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020):
</p>
<p>
In stage-up process, section 5.2.4.16, item 4:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ annotation (
<p>
Block that reduces demand of current operating chillers when there is a stage-up
command, according to ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version, March 2020),
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.16, item 1 which specifies how to start the stage-up
process of the current operating chillers; and section 5.2.4.17, item 1.a which specifies
how to start the stage-down process of the current operating chiller when the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ annotation (
Block that generates minimum bypass flow reset status when there is
stage-change command.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version,
March 2020), section 5.2.4.16, item 2.
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.16, item 2.
</p>
<p>
When there is stage-change command (<code>chaPro</code> = true) and the upstream
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -619,8 +619,8 @@ Documentation(info="<html>
<p>
Block that controls devices at the ending step of chiller staging up process.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version,
March 2020), section 5.2.4.16, item 6 and 7. These sections specify the controls of
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23,
2020), section 5.2.4.16, item 6 and 7. These sections specify the controls of
devices at the ending step of staging up process.
</p>
<p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ water-cooled primary-only parallel chiller plants with headered chilled water pu
and headered condenser water pumps, or air-cooled primary-only parallel chiller
plants with headered chilled water pumps.
This development is based on ASHRAE RP-1711 Advanced Sequences of Operation for
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft version, March 2020),
HVAC Systems Phase II – Central Plants and Hydronic Systems (Draft on March 23, 2020),
section 5.2.4.16, which specifies the step-by-step control of
devices during chiller staging up process.
</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ Documentation(info="<html>
Block that outputs cooling tower fan speed <code>yFanSpe</code> for maintaining
condenser water return temperature at setpoint. This is implemented
according to ASHRAE RP-1711 Advanced Sequences of Operation for HVAC Systems Phase II –
Central Plants and Hydronic Systems (Draft 6 on July 25, 2019), section 5.2.12.2,
Central Plants and Hydronic Systems (Draft on March 23, 2020), section 5.2.12.2,
item 2. It includes four subsequences:
</p>
<ul>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Towers.FanSpeed.ReturnWaterTemperature.Subsequences;
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Towers.FanSpeed.ReturnWaterTemperature.Subsequences;
block Coupled
"Sequence of defining cooling tower fan speed when the plant is close coupled"

Expand Down Expand Up @@ -75,6 +75,7 @@ block Coupled
final Td=Td,
final yMax=yMax,
final yMin=yMin,
final reverseActing=false,
final y_reset=yMin) "Condenser water return temperature controller"
annotation (Placement(transformation(extent={{-80,70},{-60,90}})));

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Towers.FanSpeed.ReturnWaterTemperature.Subsequences;
within Buildings.Controls.OBC.ASHRAE.PrimarySystem.ChillerPlant.Towers.FanSpeed.ReturnWaterTemperature.Subsequences;
block LessCoupled
"Sequence of defining cooling tower fan speed when the plant is not close coupled"

Expand Down Expand Up @@ -119,6 +119,7 @@ block LessCoupled
final Td=TdSupCon,
final yMax=ySupConMax,
final yMin=ySupConMin,
final reverseActing=false,
final y_reset=ySupConMin) "Condenser water supply temperature controller"
annotation (Placement(transformation(extent={{-20,-40},{0,-20}})));

Expand Down Expand Up @@ -179,6 +180,7 @@ protected
annotation (Placement(transformation(extent={{-20,40},{0,60}})));
Buildings.Controls.OBC.CDL.Continuous.MultiMax multiMax(
final nin=nChi)
"Difference of the design supply and return condenser water temperature of the enabled chiller"
annotation (Placement(transformation(extent={{20,40},{40,60}})));
Buildings.Controls.OBC.CDL.Logical.Timer tim(final t=iniPlaTim)
"Count the time after plant being enabled"
Expand Down

0 comments on commit bc425ed

Please sign in to comment.