Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redeclare Modifiers #204

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Redeclare Modifiers #204

merged 7 commits into from
Oct 18, 2022

Conversation

darenkeck-dev
Copy link
Collaborator

@darenkeck-dev darenkeck-dev commented Oct 11, 2022 •
edited
Loading

Description

Fixes redeclare modifiers

Related Issue(s)

#202

Testing

  • Integration tests are updated. Make sure tests pass.
  • Output template json from the full modelica buildings repo. Check that VAVBoxCoolingOnly has a modifier for coiHea setting it to Coils.None.

@darenkeck-dev darenkeck-dev changed the title #202 Redeclare Modifiers Redeclare Modifiers Oct 11, 2022
@darenkeck-dev darenkeck-dev marked this pull request as ready for review October 14, 2022 03:31
@darenkeck-dev
Copy link
Collaborator Author

With these changes VAVBoxCoolingOnly no longer shows the heating coil option.

Screen Shot 2022-10-18 at 1 11 57 PM

akapoor66
akapoor66 approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@akapoor66 akapoor66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Let's get this merged!

@darenkeck-dev darenkeck-dev merged commit 532b7a1 into main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akapoor66 akapoor66 akapoor66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darenkeck-dev @akapoor66