Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dk/96 visible expression #173

Merged
merged 27 commits into from
Aug 29, 2022
Merged

Dk/96 visible expression #173

merged 27 commits into from
Aug 29, 2022

Conversation

darenkeck-dev
Copy link
Collaborator

@darenkeck-dev darenkeck-dev commented Aug 16, 2022 •
edited
Loading

Description

  • Integrates suggested logic by Antoine around visibility settings for options
  • Integrates simple expression evaluation to set 'enable' and 'value' with generated 'Options'.
  • Update modifier structure, attaching modifiers to generated options

Related Issue(s)

#96
#152

Testing

Integration tests will be updated

Daren Keck added 22 commits August 15, 2022 17:29
WIP: integrate expression evaluation with enable/visible sets
e6233db
Add TODO around replaceable mods and expressions
d10e09b
Implement visibility test for 'enable' annotation
0b33f55
Set 'enable' even if no annotation is provided
d46058e
Fix typo in test package, fix typo in test
13d386c
Add and implement tests for remaining 'visible' conditions
cd6f1cd
Don't lazy load types, load on discovery
58942aa
Use 'type' to build up modification paths
076770e
Include modifiers with 'TemplateInputs'
f6472e0
Map modifiers to serializable format
093b6eb
WIP: Add redeclared parameters to test package
bb275cc
Fix type on 'getOptions'
4846c62
Simplify redeclare statements
caf55eb
WIP: Add todo around mod path buildup
31272da
WIP: remove 'getModifiers' accessor
df8890b
WIP: handle extend_clause modifiers
8629605
Update shape of serializable modifier structure
89d705f
Use correct basepath when creating modifiers
da3cf28
Change TemplateInput mods back to a list
da1d418
WIP: update modifier tests
0ad311e
WIP: update constrainby modifier test
58af86b
Include modifiers when generating replaceable template input
679467c
@darenkeck-dev darenkeck-dev marked this pull request as ready for review August 24, 2022 17:33
akapoor66
akapoor66 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Collaborator

@akapoor66 akapoor66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting tests put in as well

@darenkeck-dev darenkeck-dev merged commit 11b93f8 into main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akapoor66 akapoor66 akapoor66 approved these changes

@erikwiffin erikwiffin Awaiting requested review from erikwiffin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darenkeck-dev @akapoor66