-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#135: Initial work to Group Schedule Table Inputs #144
Conversation
I'm going to try and get incremental progress merged on this as this PR has been open for a bit. I have three remaining items:
|
Even though this is still WIP I think it is ready for review. I'm working through the algorithm to split schedule table vs. configuration page options and will remove WIP once it is in a reasonable spot. |
I have marked this as ready to review. I think this is a good intermediate point to merge. The algorithm for extracting schedule options in the template class will need to be updated as what is currently present is just a placeholder. I'm attempting to split options up in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I have a couple of questions but I suspect that it might be due to my lack of understanding of how the parser works! |
I'm going to go ahead and merge. I'm going to have a follow-on PR that does additional work to extract Schedule option groups, moving some of the schedule option extraction into the parser. |
Description
Updates test package to more closely match pattern of
dat
parameter in templatesSeparates. Update parser interface so both options and schedule options are returned.dat
parameters into a unique type for the front end, creatingScheduleGroup
andScheduleOption
typesNOTE: The algorithm started is at the
template
level, but utlimately it will need to be moved intoparser.ts
. Correctly extracting options will require inspectingElement
s.Related Issue(s)
#135
#152
#155
#156
Testing