Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#135: Initial work to Group Schedule Table Inputs #144

Merged
merged 23 commits into from
Jul 29, 2022
Merged

Conversation

darenkeck-dev
Copy link
Collaborator

@darenkeck-dev darenkeck-dev commented Jul 6, 2022

Description

  • Updates test package to more closely match pattern of dat parameter in templates

  • Separates dat parameters into a unique type for the front end, creating ScheduleGroup and ScheduleOption types. Update parser interface so both options and schedule options are returned.

NOTE: The algorithm started is at the template level, but utlimately it will need to be moved into parser.ts. Correctly extracting options will require inspecting Elements.

Related Issue(s)

#135
#152
#155
#156

Testing

  • Integration Tests updated

@darenkeck-dev
Copy link
Collaborator Author

darenkeck-dev commented Jul 19, 2022

I'm going to try and get incremental progress merged on this as this PR has been open for a bit. I have three remaining items:

  • redeclared packages are not yet being correctly handled with the Modifier class. This is causing a local test (tests that run against the full template library) to fail.

  • Some of the inheritance behavior is not working with redeclared models

  • Get some initial work in on formatting and separating out schedule table options.

@darenkeck-dev
Copy link
Collaborator Author

Even though this is still WIP I think it is ready for review.

I'm working through the algorithm to split schedule table vs. configuration page options and will remove WIP once it is in a reasonable spot.

@darenkeck-dev darenkeck-dev changed the title WIP: #135: Group Schedule Table Inputs #135: Group Schedule Table Inputs Jul 29, 2022
@darenkeck-dev darenkeck-dev marked this pull request as ready for review July 29, 2022 00:30
@darenkeck-dev darenkeck-dev changed the title #135: Group Schedule Table Inputs #135: Initial work to Group Schedule Table Inputs Jul 29, 2022
@darenkeck-dev
Copy link
Collaborator Author

I have marked this as ready to review. I think this is a good intermediate point to merge.

The algorithm for extracting schedule options in the template class will need to be updated as what is currently present is just a placeholder. I'm attempting to split options up in the template layer of the parser, but it is likely this work will need to move to parser.ts and work with elements to correctly consume the annotations that will be introduced.

Copy link
Collaborator

@akapoor66 akapoor66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@yvesgurcan
Copy link
Collaborator

I have a couple of questions but I suspect that it might be due to my lack of understanding of how the parser works!

@darenkeck-dev
Copy link
Collaborator Author

I'm going to go ahead and merge. I'm going to have a follow-on PR that does additional work to extract Schedule option groups, moving some of the schedule option extraction into the parser.

@darenkeck-dev darenkeck-dev merged commit 78527cf into main Jul 29, 2022
@Flintonian Flintonian added this to the 01: Parser (BE) milestone Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants