Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeclare modifiers not getting generated for VAVBoxCoolingOnly template #202

Closed
darenkeck-dev opened this issue Oct 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@darenkeck-dev
Copy link
Collaborator

Description

A modifier in the VAVBoxCoolingOnly template is not generating the expected linkage modifiers.

// in Buildings/Templates/ZoneEquipment/VAVBoxCoolingOnly.mo
within Buildings.Templates.ZoneEquipment;
model VAVBoxCoolingOnly "VAV terminal unit cooling only"
  extends Buildings.Templates.ZoneEquipment.Interfaces.VAVBox(
    final typ=Buildings.Templates.ZoneEquipment.Types.Configuration.VAVBoxCoolingOnly,
    redeclare final Buildings.Templates.Components.Coils.None coiHea,
    redeclare replaceable Buildings.Templates.ZoneEquipment.Components.Controls.G36VAVBoxCoolingOnly
      ctl "Guideline 36 controller for VAV terminal unit cooling only");

A modifier is NOT generated for redeclare final Buildings.Templates.Components.Coils.None coiHea and redeclare replaceable Buildings.Templates.ZoneEquipment.Components.Controls.G36VAVBoxCoolingOnly ctl.

VAVBoxCoolingOnly linkage schema output looks as follows:

{
  "modifiers": {
    "Buildings.Templates.ZoneEquipment.Interfaces.PartialAirTerminal.typ": {
      "expression": {
        "operator": "none",
        "operands": [
          "Buildings.Templates.ZoneEquipment.Types.Configuration.VAVBoxCoolingOnly"
        ]
      },
      "final": true
    }
  }
}

Related

#152

@darenkeck-dev darenkeck-dev added the bug Something isn't working label Oct 11, 2022
@darenkeck-dev darenkeck-dev added this to the 01: Parser (BE) milestone Oct 11, 2022
@darenkeck-dev darenkeck-dev self-assigned this Oct 11, 2022
@darenkeck-dev
Copy link
Collaborator Author

Added tests and the redeclare mod is now getting generated as expected. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant