Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum word count to a review #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add maximum word count to a review #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions apps/web/models/forms/review_form.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,22 @@
from lib.terms import is_valid_term

REVIEW_MINIMUM_LENGTH = 100

REVIEW_MAXIMUM_WORDS = 200

class ReviewForm(forms.ModelForm):

def get_word_count(string): # Finds word count of given string.
words = 1
for i in range(len(string)):
if string[i] == " ":
if string[i-1] != " " and string[i-1] != ")":
words += 1

elif string[i] == "-":
if string[i-1] != "-":
words += 1
return words

def clean_term(self):
term = self.cleaned_data['term'].upper()
if is_valid_term(term):
Expand Down Expand Up @@ -39,7 +51,14 @@ def clean_comments(self):
REVIEW_MINIMUM_LENGTH
)
)


if get_word_count(review) > REVIEW_MAXIMUM_WORDS: # Check if review has > 200 words
raise ValidationError(
"Please limit your review to at most {} 250".format(
REVIEW_MAXIMUM_WORDS
)
)

return review

class Meta:
Expand Down