Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor #1784

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

I refactored the provider optimizer and fixed various bugs it had. I did the refactor in files with "_refator" suffix to be able to test the new optimizer while not hurting the current one


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Nov 20, 2024

Test Results

2 314 tests   - 18   2 312 ✅  - 20   26m 56s ⏱️ +21s
  143 suites  -  2       0 💤 ± 0 
    6 files    -  1       2 ❌ + 2 

For more details on these failures, see this check.

Results for commit 3aea031. ± Comparison against base commit c15d99c.

This pull request removes 156 and adds 138 tests. Note that renamed tests count towards both.
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_1.2
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_2.5
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheExpirationMultiplier/Multiplier_of_200
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_No_Hash#01
github.com/lavanet/lava/v4/ecosystem/cache ‑ TestCacheFailSetWithInvalidRequestBlock/Finalized_After_delay_With_Hash
…
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__no_internal_paths_in_spec__both_ws_and_http_node_urls
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__no_internal_paths_in_spec__multiple_http_node_urls_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__no_internal_paths_in_spec__single_http_node_url_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__no_internal_paths_in_spec__single_ws_node_url__should_error
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_mixed_internal_paths_in_spec_and_root_is_disabled_http_and_ws_is_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_mixed_internal_paths_in_spec_and_root_is_disabled_http_only_is_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_mixed_internal_paths_in_spec_and_root_is_disabled_ws_only_is_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_multiple_ws_internal_paths_in_spec__http_and_ws_is_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_ws_internal_paths_in_spec__http_and_ws_is_configured
github.com/lavanet/lava/v4/protocol/chainlib ‑ TestChainRouterWithInternalPaths/jsonrpc__with_internal_paths_and_ws_internal_paths_in_spec__only_http_is_configured
…

♻️ This comment has been updated with latest results.

@oren-lava oren-lava changed the title refactor: CNS-1008 provider optimizer refactor refactor: CNS-1008 - Optimizer Refactor Part 2: provider optimizer refactor Nov 26, 2024
@oren-lava oren-lava changed the title refactor: CNS-1008 - Optimizer Refactor Part 2: provider optimizer refactor refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants