-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor #1784
Open
oren-lava
wants to merge
23
commits into
main
Choose a base branch
from
CNS-1008-score-store-refactor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() + minor test fix
Test Results2 314 tests - 18 2 312 ✅ - 20 26m 56s ⏱️ +21s For more details on these failures, see this check. Results for commit 3aea031. ± Comparison against base commit c15d99c. This pull request removes 156 and adds 138 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
oren-lava
changed the title
refactor: CNS-1008 provider optimizer refactor
refactor: CNS-1008 - Optimizer Refactor Part 2: provider optimizer refactor
Nov 26, 2024
oren-lava
changed the title
refactor: CNS-1008 - Optimizer Refactor Part 2: provider optimizer refactor
refactor: CNS-1008 - Optimizer Refactor Part 1: provider optimizer refactor
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
I refactored the provider optimizer and fixed various bugs it had. I did the refactor in files with "_refator" suffix to be able to test the new optimizer while not hurting the current one
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changemain
branchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...