Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CNS-891: Same provider conflict #1344

Closed
wants to merge 126 commits into from
Closed

feat: CNS-891: Same provider conflict #1344

wants to merge 126 commits into from

Conversation

shleikes
Copy link
Collaborator

@shleikes shleikes commented Mar 31, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced logging for better traceability and debugging.
    • Corrected typos and improved code readability.
    • Improved consistency and accuracy in block finalization and conflict detection logic.

  • New Features

    • Added RelayFinalization message with detailed block finalization attributes.
    • Introduced new methods for handling consensus and finalization data.

  • Tests

    • Added comprehensive tests for median calculation across different data types.

  • Refactor

    • Streamlined conflict detection mechanisms by consolidating conflict parameters.
    • Replaced debug logs with trace logs to provide more detailed logging information.

  • Chores

    • Removed unused debug constants.
    • Updated @types/node version in package.json.

@shleikes shleikes self-assigned this Mar 31, 2024
oren-lava
oren-lava requested changes Apr 1, 2024
View reviewed changes
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Show resolved Hide resolved
x/conflict/keeper/conflict.go Outdated Show resolved Hide resolved
x/conflict/types/relay_finalization_metadata.go Outdated Show resolved Hide resolved
protocol/integration/protocol_test.go Outdated Show resolved Hide resolved
protocol/integration/protocol_test.go Outdated Show resolved Hide resolved
x/conflict/keeper/conflict_test.go Outdated Show resolved Hide resolved
@shleikes shleikes requested a review from oren-lava April 3, 2024 14:05
@shleikes shleikes requested a review from Yaroms April 9, 2024 08:28
Yaroms
Yaroms reviewed Apr 9, 2024
View reviewed changes
x/conflict/types/relay_finalization_metadata.go Outdated Show resolved Hide resolved
proto/lavanet/lava/conflict/conflict_data.proto Outdated Show resolved Hide resolved
x/conflict/keeper/msg_server_detection.go Outdated Show resolved Hide resolved
x/conflict/keeper/msg_server_detection.go Outdated Show resolved Hide resolved
x/conflict/keeper/conflict.go Outdated Show resolved Hide resolved
x/conflict/keeper/conflict.go Outdated Show resolved Hide resolved
x/conflict/keeper/conflict.go Outdated Show resolved Hide resolved
x/conflict/keeper/conflict.go Outdated Show resolved Hide resolved
@shleikes shleikes requested a review from Yaroms April 10, 2024 14:17
ranlavanet
ranlavanet requested changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@ranlavanet ranlavanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt finish. got to finalization consensus

protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
proto/lavanet/lava/conflict/conflict_data.proto Outdated Show resolved Hide resolved
proto/lavanet/lava/conflict/conflict_data.proto Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
ranlavanet
ranlavanet requested changes Apr 21, 2024
View reviewed changes
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/finalization_consensus.go Outdated Show resolved Hide resolved
protocol/lavaprotocol/response_builder.go Outdated Show resolved Hide resolved
protocol/rpcconsumer/rpcconsumer.go Show resolved Hide resolved
protocol/rpcconsumer/rpcconsumer_server.go Outdated Show resolved Hide resolved
protocol/rpcprovider/rpcprovider_server.go Outdated Show resolved Hide resolved
utils/lavaslices/slices.go Outdated Show resolved Hide resolved
ranlavanet
ranlavanet previously approved these changes Apr 25, 2024
View reviewed changes
@shleikes shleikes requested review from ranlavanet and oren-lava and removed request for oren-lava April 25, 2024 11:14
@shleikes
Fix some errors usage in finalization consensus
ebe5ab9
@shleikes
Create an interface for finalization consensus
983ef14
@shleikes
Add a function to chain listener to get the listening address, and us…
ccf4870 
…e it in test setup
@shleikes
Small fix to uniqueAddressGenerator
204d863
@shleikes
Remove some comments
e881474
@shleikes
Add log handling for error slice
1813214
@shleikes
Remove String() function for finalization consensus
0908545
@shleikes
Add a benchmark test for finalization consensus GetExpectedBlockHeight
7941395
@shleikes
Finalization consensus GetExpectedBlockHeight improvement
91a859c
@shleikes
Fix a bug in GetConsumerSessionInstanceFromEndpoint
36f0d14
@shleikes
Fix a bug in GetSessions
ebbc5bf
@shleikes
Small bug fix in finalization consensus tests
0d92ff0
@shleikes
Add a benchmark to finalization consensus UpdateFinalizedHashes
9422287
@shleikes
Another improvement to the finalization consensus GetExpectedBlockHei…
319a744 
…ght func
@shleikes
Small fix to lavalog
95c4bdb
@shleikes
Add a safe check to make sure the new reported finalized block is newer
f465d82
@shleikes
Merge branch 'CNS-891-same-provider-conflict-benchmark-test' into CNS…
bde467a 
…-891-same-provider-conflict-is-disabled
omerlavanet
omerlavanet previously approved these changes Aug 6, 2024
View reviewed changes
@shleikes shleikes marked this pull request as draft August 6, 2024 20:03
@shleikes shleikes changed the base branch from main to CNS-891-same-provider-conflict-target August 6, 2024 20:08
@shleikes shleikes changed the base branch from CNS-891-same-provider-conflict-target to main August 6, 2024 20:09
@shleikes shleikes dismissed omerlavanet’s stale review August 6, 2024 20:09

The base branch was changed.

@shleikes shleikes changed the base branch from main to CNS-891-same-provider-conflict-target August 6, 2024 20:10
@shleikes
Copy link
Collaborator Author

shleikes commented Aug 7, 2024

Closed in favor of the new PR: #1614

@shleikes shleikes closed this Aug 7, 2024
@shleikes shleikes deleted the CNS-891-same-provider-conflict-is-disabled branch August 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@oren-lava oren-lava oren-lava left review comments

@ranlavanet ranlavanet ranlavanet left review comments

@Yaroms Yaroms Yaroms left review comments

@omerlavanet omerlavanet omerlavanet left review comments

Assignees

@shleikes shleikes

Labels
C:proto C:protocol C:specs C:x/conflict C:x/pairing C:x/spec size/XXL Team:Consensus Team:Protocol Type: Build Type: CI Type: Proto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shleikes @omerlavanet @Yaroms @ranlavanet @oren-lava