-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Plugin Update Checker #1121
Open
Neuheit
wants to merge
3
commits into
lavalink-devs:dev
Choose a base branch
from
Neuheit:feature/plugin-update-verifier
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,9 +9,11 @@ import java.io.FileOutputStream | |
import java.io.InputStream | ||
import java.net.URL | ||
import java.net.URLClassLoader | ||
import java.net.HttpURLConnection | ||
import java.nio.channels.Channels | ||
import java.util.* | ||
import java.util.jar.JarFile | ||
import io.github.z4kn4fein.semver.toVersion | ||
|
||
@SpringBootApplication | ||
class PluginManager(val config: PluginsConfig) { | ||
|
@@ -83,6 +85,37 @@ class PluginManager(val config: PluginsConfig) { | |
val file = File(directory, declaration.canonicalJarName) | ||
downloadJar(file, url) | ||
} | ||
|
||
checkPluginForUpdates(declaration) | ||
} | ||
} | ||
|
||
private fun checkPluginForUpdates(declaration: Declaration) { | ||
val splitPath = declaration.url.split('/') | ||
|
||
val baseSplitPath = splitPath.dropLast(2) | ||
val basePath = baseSplitPath.joinToString("/") + "/maven-metadata.xml" | ||
|
||
val connection = URL(basePath).openConnection() as HttpURLConnection | ||
connection.inputStream.bufferedReader().use { | ||
val lines = it.readLines() | ||
for (line in lines) { | ||
val regex = "<latest>(.*?)</latest>".toRegex() | ||
val match = regex.find(line) | ||
val latest = match?.groups?.get(1)?.value | ||
if (latest != null) { | ||
val latestVersion = latest.toVersion() | ||
val currentVersion = declaration.version.toVersion() | ||
|
||
if(latestVersion > currentVersion) { | ||
log.warn("A newer version of ${declaration.name} was found: $latestVersion. " + | ||
"The current version is $currentVersion.") | ||
} else { | ||
log.info("Plugin ${declaration.name} is up to date") | ||
} | ||
break | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please not regex XML? |
||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this lib really needed? we already have a way to parse semver in
Lavalink/protocol/src/commonMain/kotlin/dev/arbjerg/lavalink/protocol/v4/info.kt
Line 59 in 88cc859
you would just need to add a method to compare them which should be easy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I didnt see this thanks!