Expose lavalink sessions for plugins #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
two such example plugins would be https://github.com/topi314/LavaLyrics or https://github.com/topi314/LavaQueue |
topi314
force-pushed
the
feature/expose-sessions-to-plugins
branch
from
ac20e08 to
a483714
Compare
freyacodes
reviewed
Apr 28, 2024
topi314
force-pushed
the
feature/expose-sessions-to-plugins
branch
from
a483714 to
4127f24
Compare
DRSchlaubi
pushed a commit
to DRSchlaubi/Lavalink
that referenced
this pull request
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the ability for plugins to easily access the sessions without having to import the lavalink server as a dependency
in some plugins i want to have rest routes such as
/v4/sessions/{SESSION_ID}/players/{GUILD_ID}this is rather annoying atm since you have to add the lavalink server as a compile only dependency