fix: allow element xpath selection without filter

lavague-ai · Oct 4, 2024 · e9483b0 · e9483b0
1 parent 05719be
commit e9483b0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/lavague-integrations/drivers/lavague-drivers-selenium/lavague/drivers/selenium/node.py b/lavague-integrations/drivers/lavague-drivers-selenium/lavague/drivers/selenium/node.py
@@ -150,6 +150,9 @@ def find_element(xpath):
 
         self._element = find_element(local_xpath)
 
+        if not self._element:
+            raise ElementNotFoundException(self.xpath)
+
     def exit_context(self):
         if hasattr(self, "_element"):
             self.driver.switch_to.default_content()

diff --git a/lavague-sdk/lavague/sdk/base_driver/javascript.py b/lavague-sdk/lavague/sdk/base_driver/javascript.py
@@ -79,7 +79,7 @@ def js_wrap_function_call(fn: str):
             && (e.scrollHeight > e.clientHeight || e.scrollWidth > e.clientWidth)) {
             evts.push('SCROLL');
         }
-        if (filterTypes && evts.length) {
+        if (filterTypes && filterTypes.length) {
             evts = evts.filter(t => filterTypes.includes(t));
         }
         if (nonInteractives && evts.length === 0) {