Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AES-CTR and AES-CBC #265

Merged
merged 19 commits into from
Nov 5, 2023
Merged

Add AES-CTR and AES-CBC #265

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f97e11f
add: AES-CTR and AES-CBC mode
kentakayama Oct 23, 2023
54a2bfc
add: AES-CTR and AEC-CBC tests
kentakayama Oct 23, 2023
31918c6
update: skip decrypt_known_good_aeskw_non_aead_test() with MbedTLS 2.28
kentakayama Oct 23, 2023
7a5e830
add: non_aead functions to test_crypto
kentakayama Oct 23, 2023
19c0507
update: returns T_COSE_ERR_AAD_WITH_NON_AEAD if necessary
kentakayama Oct 30, 2023
6012aa6
update: confirm that the t_cose_encrypt_enc returns T_COSE_ERR_AAD_WI…
kentakayama Oct 30, 2023
5425e25
update: move all params to unprotected header only for non AEAD
kentakayama Nov 4, 2023
a5d30a6
add: enc-dec test for AES-CTR and AES-CBC
kentakayama Nov 4, 2023
3b0d99a
merge: from dev
kentakayama Nov 4, 2023
65c9ec7
update: allow algorithm id in unprotected header
kentakayama Nov 4, 2023
f47406f
fix: t_cose_param_find_alg_id_unprot
kentakayama Nov 4, 2023
f3d2fc6
del: unused variable dummy_length
kentakayama Nov 4, 2023
e100210
del: psa_crypto_init()
kentakayama Nov 4, 2023
4c30d47
add: appropriate cast
kentakayama Nov 4, 2023
af6fc01
fix: typo
kentakayama Nov 4, 2023
f8c159e
update: AES-KW + non AEAD test binary
kentakayama Nov 4, 2023
3c1cd24
merge: dev
kentakayama Nov 4, 2023
0a8b9fe
update: move AES-CTR and AES-CBC test case into test/data/*diag
kentakayama Nov 4, 2023
01b9086
fix: nit
kentakayama Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
375 changes: 374 additions & 1 deletion crypto_adapters/t_cose_openssl_crypto.c
View file
Open in desktop

Large diffs are not rendered by default.

262 changes: 262 additions & 0 deletions crypto_adapters/t_cose_psa_crypto.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1080,6 +1080,18 @@ t_cose_crypto_make_symmetric_key_handle(int32_t cose_algorithm_id,
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 128;
break;
case T_COSE_ALGORITHM_A128CTR:
psa_algorithm = PSA_ALG_CTR;
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 128;
break;
case T_COSE_ALGORITHM_A128CBC:
psa_algorithm = PSA_ALG_CBC_PKCS7; // RFC9459 requests to use padding
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 128;
break;

case T_COSE_ALGORITHM_A192GCM:
case T_COSE_ALGORITHM_A192KW:
Expand All @@ -1088,6 +1100,18 @@ t_cose_crypto_make_symmetric_key_handle(int32_t cose_algorithm_id,
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 192;
break;
case T_COSE_ALGORITHM_A192CTR:
psa_algorithm = PSA_ALG_CTR;
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 192;
break;
case T_COSE_ALGORITHM_A192CBC:
psa_algorithm = PSA_ALG_CBC_PKCS7; // RFC9459 requests to use padding
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 192;
break;

case T_COSE_ALGORITHM_A256GCM:
case T_COSE_ALGORITHM_A256KW:
Expand All @@ -1096,6 +1120,18 @@ t_cose_crypto_make_symmetric_key_handle(int32_t cose_algorithm_id,
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 256;
break;
case T_COSE_ALGORITHM_A256CTR:
psa_algorithm = PSA_ALG_CTR;
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 256;
break;
case T_COSE_ALGORITHM_A256CBC:
psa_algorithm = PSA_ALG_CBC_PKCS7; // RFC9459 requests to use padding
psa_keytype = PSA_KEY_TYPE_AES;
psa_key_usage = PSA_KEY_USAGE_ENCRYPT | PSA_KEY_USAGE_DECRYPT | PSA_KEY_USAGE_EXPORT;
key_bitlen = 256;
break;

case T_COSE_ALGORITHM_HMAC256:
psa_keytype = PSA_KEY_TYPE_HMAC;
Expand Down Expand Up @@ -1176,6 +1212,58 @@ aead_byte_count(const int32_t cose_algorithm_id,
}


/* Compute size of ciphertext, given size of plaintext. Returns
* SIZE_MAX if the algorithm is unknown. Also returns the tag
* length. */
static size_t
non_aead_byte_count(const int32_t cose_algorithm_id,
size_t plain_text_len)
{
/* This works for CTR (counter) and CBC, non AEAD algorithms,
* but can be augmented for others.
*
* For both CTR and CBC as used by COSE and HPKE, the authentication tag is not
* appended.
*
* For CTR the ciphertext length is the same as the plaintext length.
* (This is not true of other ciphers).
* https://crypto.stackexchange.com/questions/26783/ciphertext-and-tag-size-and-iv-transmission-with-aes-in-gcm-mode
*
* For CBC the plaintext will be padded from 1 bytes to the block size.
* The block size is 16 bytes for all A128CBC, A192CBC and A256CBC.
* If the plaintext size is 30 bytes for A128CBC, 2 bytes padding will be inserted,
* and each padding byte has value 0x02.
*/

size_t padding_length = 0;
switch(cose_algorithm_id) {
case T_COSE_ALGORITHM_A128CTR:
case T_COSE_ALGORITHM_A192CTR:
case T_COSE_ALGORITHM_A256CTR:
return plain_text_len;
case T_COSE_ALGORITHM_A128CBC:
case T_COSE_ALGORITHM_A192CBC:
case T_COSE_ALGORITHM_A256CBC:
padding_length = 16 - plain_text_len % 16;
break;
default:
return SIZE_MAX;
}

if(plain_text_len > (SIZE_MAX - padding_length)) {
/* The extremely rare case where plain_text_len
* is almost SIZE_MAX in length and the length
* additions below will fail. This error is not
* the right one, but the case is so rare that
* it's not worth the trouble of making up some
* other error. This check is here primarily
* for static analyzers. */
return SIZE_MAX;
}
return plain_text_len + padding_length;
}


static enum t_cose_err_t
aead_psa_status_to_t_cose_err(psa_status_t status, enum t_cose_err_t deflt)
{
Expand All @@ -1194,6 +1282,8 @@ aead_psa_status_to_t_cose_err(psa_status_t status, enum t_cose_err_t deflt)

case PSA_ERROR_INVALID_SIGNATURE: return T_COSE_ERR_DATA_AUTH_FAILED;

case PSA_ERROR_INVALID_PADDING: return T_COSE_ERR_BAD_PADDING;

default: return deflt;
}
}
Expand Down Expand Up @@ -1260,6 +1350,96 @@ t_cose_crypto_aead_encrypt(const int32_t cose_algorithm_id,
}


/*
* See documentation in t_cose_crypto.h
*/
enum t_cose_err_t
t_cose_crypto_non_aead_encrypt(const int32_t cose_algorithm_id,
struct t_cose_key key,
struct q_useful_buf_c nonce,
struct q_useful_buf_c plaintext,
struct q_useful_buf ciphertext_buffer,
struct q_useful_buf_c *ciphertext)
{
// based on https://mbed-tls.readthedocs.io/en/latest/getting_started/psa/

psa_status_t status;
psa_algorithm_t psa_algorithm_id;
psa_cipher_operation_t operation = PSA_CIPHER_OPERATION_INIT;
size_t dummy_length = 0;

/* Pretty sure the optimizer will do good things with this switch. */
switch (cose_algorithm_id) {
case T_COSE_ALGORITHM_A128CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;
case T_COSE_ALGORITHM_A192CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;
case T_COSE_ALGORITHM_A256CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;

// RFC9459 requests to use padding
case T_COSE_ALGORITHM_A128CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
case T_COSE_ALGORITHM_A192CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
case T_COSE_ALGORITHM_A256CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
default:
return T_COSE_ERR_UNSUPPORTED_CIPHER_ALG;
}

if(ciphertext_buffer.ptr == NULL) {
/* Called in length calculation mode. Return length & exit. */
ciphertext->len = non_aead_byte_count(cose_algorithm_id,
plaintext.len);;
return T_COSE_SUCCESS;
}

status = psa_crypto_init();
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
if(status != PSA_SUCCESS) {
goto Done;
}

/* Encrypt the ciphertext */
status = psa_cipher_encrypt_setup(&operation, key.key.handle, psa_algorithm_id);
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_set_iv(&operation, nonce.ptr, nonce.len);
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_update(&operation,
plaintext.ptr,
plaintext.len,
ciphertext_buffer.ptr,
ciphertext_buffer.len,
&ciphertext->len);
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_finish(&operation,
ciphertext_buffer.ptr + ciphertext->len,
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
ciphertext_buffer.len - ciphertext->len,
&dummy_length);
if(status != PSA_SUCCESS) {
goto Done;
}

ciphertext->len += dummy_length;
ciphertext->ptr = ciphertext_buffer.ptr;

Done:
return aead_psa_status_to_t_cose_err(status, T_COSE_ERR_ENCRYPT_FAIL);
}


/*
* See documentation in t_cose_crypto.h
*/
Expand Down Expand Up @@ -1303,6 +1483,88 @@ t_cose_crypto_aead_decrypt(const int32_t cose_algorithm_id,
}


/*
* See documentation in t_cose_crypto.h
*/
enum t_cose_err_t
t_cose_crypto_non_aead_decrypt(const int32_t cose_algorithm_id,
struct t_cose_key key,
struct q_useful_buf_c nonce,
struct q_useful_buf_c ciphertext,
struct q_useful_buf plaintext_buffer,
struct q_useful_buf_c *plaintext)
{
// based on https://mbed-tls.readthedocs.io/en/latest/getting_started/psa/

psa_status_t status;
psa_algorithm_t psa_algorithm_id;
psa_cipher_operation_t operation = PSA_CIPHER_OPERATION_INIT;
size_t dummy_length = 0;

/* Pretty sure the optimizer will do good things with this switch. */
switch (cose_algorithm_id) {
case T_COSE_ALGORITHM_A128CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;
case T_COSE_ALGORITHM_A192CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;
case T_COSE_ALGORITHM_A256CTR:
psa_algorithm_id = PSA_ALG_CTR;
break;

// RFC9459 requests to use padding
case T_COSE_ALGORITHM_A128CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
case T_COSE_ALGORITHM_A192CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
case T_COSE_ALGORITHM_A256CBC:
psa_algorithm_id = PSA_ALG_CBC_PKCS7;
break;
default:
return T_COSE_ERR_UNSUPPORTED_CIPHER_ALG;
}

status = psa_crypto_init();
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
if(status != PSA_SUCCESS) {
goto Done;
}

/* Decrypt the ciphertext */
status = psa_cipher_decrypt_setup(&operation, key.key.handle, psa_algorithm_id);
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_set_iv(&operation, nonce.ptr, nonce.len);
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_update(&operation,
ciphertext.ptr,
ciphertext.len,
plaintext_buffer.ptr,
plaintext_buffer.len,
&plaintext->len);
if(status != PSA_SUCCESS) {
goto Done;
}
status = psa_cipher_finish(&operation,
plaintext_buffer.ptr + plaintext->len,
kentakayama marked this conversation as resolved.
Show resolved Hide resolved
plaintext_buffer.len - plaintext->len,
&dummy_length);
if(status != PSA_SUCCESS) {
goto Done;
}

plaintext->len += dummy_length;
plaintext->ptr = plaintext_buffer.ptr;

Done:
return aead_psa_status_to_t_cose_err(status, T_COSE_ERR_DECRYPT_FAIL);
}


/*
* See documentation in t_cose_crypto.h
Expand Down
Loading