fix: rockspec info JSON was generated incorrectly #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwaldren-ld
force-pushed
the
cw/fix-rockspec-info-json
branch
from
e50af44
to
08695a9
Compare
cwaldren-ld
force-pushed
the
cw/fix-rockspec-info-json
branch
from
08695a9
to
c7368b1
Compare
keelerm84
approved these changes
Feb 7, 2024
cwaldren-ld
added a commit
that referenced
this pull request
Feb 7, 2024
🤖 I have created a release *beep* *boop* --- ## [2.0.6](v2.0.5...v2.0.6) (2024-02-07) ### Bug Fixes * rockspec info JSON was generated incorrectly ([#88](#88)) ([8488c38](8488c38)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: Casey Waldren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
rockspec-infoworkflow, we create a JSON object that contains rockspec versions/filenames that other steps can use.The JSON string wasn't outputted correctly, preventing
fromJSON(info)from returning an object with accessible properties.This commit both fixes it and makes it easier to read by utilizing
jqto create the JSON string.I've tested the
manual-publishandrelease-pleaseworkflows on this PR (although can't test the full release flow until this is merged.)