Skip to content

Commit

Permalink
ci: bump cpp SDK to bring in user-agent fix (#92)
Browse files Browse the repository at this point in the history
CPP server had a bug where it was sending a `CPPClient` as its
user-agent. This bumps the default version used in Lua's CI and
examples.

This also updates the README minimum versions since this bug affects
usage statistics.
  • Loading branch information
cwaldren-ld authored Feb 16, 2024
1 parent 6d1259f commit d5c3ed2
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/actions/install-cpp-sdk-redis/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
version:
required: true
description: "Version of the C++ SDK with Redis Source."
default: "launchdarkly-cpp-server-redis-source-v2.1.0"
default: "launchdarkly-cpp-server-redis-source-v2.1.2"
path:
description: "Where to download the SDK."
default: "cpp-sdk"
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ If Redis support is desired, then it optionally depends on the C++ server-side S

| Dependency | Minimum Version | Notes |
|--------------------------------|------------------------------------------------------------------------------------------------------------|--------------------------------------------|
| C++ Server-Side SDK | [3.3.0](https://github.com/launchdarkly/cpp-sdks/releases/tag/launchdarkly-cpp-server-v3.3.0) | Required dependency. |
| C++ Server-Side SDK with Redis | [2.1.0](https://github.com/launchdarkly/cpp-sdks/releases/tag/launchdarkly-cpp-server-redis-source-v2.1.0) | Optional, if using Redis as a data source. |
| C++ Server-Side SDK | [3.3.2](https://github.com/launchdarkly/cpp-sdks/releases/tag/launchdarkly-cpp-server-v3.3.2) | Required dependency. |
| C++ Server-Side SDK with Redis | [2.1.2](https://github.com/launchdarkly/cpp-sdks/releases/tag/launchdarkly-cpp-server-redis-source-v2.1.2) | Optional, if using Redis as a data source. |


3rd Party Dependencies
Expand Down
2 changes: 1 addition & 1 deletion examples/hello-haproxy/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN add-apt-repository ppa:mhier/libboost-latest && \
apt-get update && \
apt-get install -y boost1.81

RUN curl https://github.com/launchdarkly/cpp-sdks/releases/download/launchdarkly-cpp-server-v3.3.1/linux-gcc-x64-dynamic.zip -L -o /tmp/sdk.zip && \
RUN curl https://github.com/launchdarkly/cpp-sdks/releases/download/launchdarkly-cpp-server-v3.3.2/linux-gcc-x64-dynamic.zip -L -o /tmp/sdk.zip && \
mkdir ./cpp-sdk && \
unzip /tmp/sdk.zip -d ./cpp-sdk && \
rm /tmp/sdk.zip
Expand Down
2 changes: 1 addition & 1 deletion examples/hello-nginx/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ RUN add-apt-repository ppa:mhier/libboost-latest && \


RUN mkdir cpp-sdk-libs
RUN git clone --branch launchdarkly-cpp-server-v3.3.1 https://github.com/launchdarkly/cpp-sdks.git && \
RUN git clone --branch launchdarkly-cpp-server-v3.3.2 https://github.com/launchdarkly/cpp-sdks.git && \
cd cpp-sdks && \
mkdir build-dynamic && \
cd build-dynamic && \
Expand Down

0 comments on commit d5c3ed2

Please sign in to comment.