Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Upgrade edgekv bundled files to 0.6.3 #610

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

ctawiah
Copy link
Contributor

@ctawiah ctawiah commented Oct 5, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Describe alternatives you've considered

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

@kinyoklion kinyoklion changed the title Upgraded edgekv bundled files to 0.6.3 feat: Upgrade edgekv bundled files to 0.6.3 Oct 7, 2024
@ryanoglesby08
Copy link

Hello, is there a reason why this PR is still in draft and has not progressed further?

I'm from Grainger and am the one who initially reported the outdated edgekv.js file. I've tested the LD Akamai SDK v1.1.17-beta.1 and confirmed it works as expected. Is this PR going to be merged and released soon? We would like to use it!

The Akamai SDK is currently unusable for new EdgeWorker implementations without this PR.

Copy link
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 18669 bytes
Size limit: 21000

Copy link
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15292 bytes
Size limit: 20000

Copy link
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19414 bytes
Size limit: 21000

@ctawiah ctawiah marked this pull request as ready for review November 14, 2024 23:33
@ctawiah ctawiah requested a review from a team as a code owner November 14, 2024 23:33
@kinyoklion kinyoklion merged commit 58dfec6 into main Nov 14, 2024
26 checks passed
@kinyoklion kinyoklion deleted the ctawiah/upgrade-akamai-sdk-edgekv-version branch November 14, 2024 23:38
@github-actions github-actions bot mentioned this pull request Nov 14, 2024
@ctawiah
Copy link
Contributor Author

ctawiah commented Nov 14, 2024

Hello, is there a reason why this PR is still in draft and has not progressed further?

I'm from Grainger and am the one who initially reported the outdated edgekv.js file. I've tested the LD Akamai SDK v1.1.17-beta.1 and confirmed it works as expected. Is this PR going to be merged and released soon? We would like to use it!

The Akamai SDK is currently unusable for new EdgeWorker implementations without this PR.

Great timing! We’re actually preparing to release it right now, just before your comment came in. Thanks for testing and confirming that v1.1.17-beta.1 works as expected. This PR will be merged and released shortly. Thanks for your patience and collaboration!

kinyoklion pushed a commit that referenced this pull request Nov 14, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>akamai-edgeworker-sdk-common: 1.3.2</summary>

##
[1.3.2](akamai-edgeworker-sdk-common-v1.3.1...akamai-edgeworker-sdk-common-v1.3.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0
</details>

<details><summary>akamai-server-base-sdk: 2.1.20</summary>

##
[2.1.20](akamai-server-base-sdk-v2.1.19...akamai-server-base-sdk-v2.1.20)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.3.1 to
^1.3.2
    * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0
</details>

<details><summary>akamai-server-edgekv-sdk: 1.3.0</summary>

##
[1.3.0](akamai-server-edgekv-sdk-v1.2.1...akamai-server-edgekv-sdk-v1.3.0)
(2024-11-14)


### Features

* Upgrade edgekv bundled files to 0.6.3
([#610](#610))
([58dfec6](58dfec6))


### Dependencies

* The following workspace dependencies were updated
  * dependencies
* @launchdarkly/akamai-edgeworker-sdk-common bumped from ^1.3.1 to
^1.3.2
    * @launchdarkly/js-server-sdk-common bumped from ^2.9.1 to ^2.10.0
</details>

<details><summary>cloudflare-server-sdk: 2.6.2</summary>

##
[2.6.2](cloudflare-server-sdk-v2.6.1...cloudflare-server-sdk-v2.6.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.1 to 2.5.2
</details>

<details><summary>js-server-sdk-common: 2.10.0</summary>

##
[2.10.0](js-server-sdk-common-v2.9.1...js-server-sdk-common-v2.10.0)
(2024-11-14)


### Features

* Add support for getting the logger from server-side SDKs.
([#684](#684))
([1c411a1](1c411a1))
</details>

<details><summary>js-server-sdk-common-edge: 2.5.2</summary>

##
[2.5.2](js-server-sdk-common-edge-v2.5.1...js-server-sdk-common-edge-v2.5.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.9.1 to 2.10.0
</details>

<details><summary>node-server-sdk: 9.7.2</summary>

##
[9.7.2](node-server-sdk-v9.7.1...node-server-sdk-v9.7.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.9.1 to 2.10.0
</details>

<details><summary>node-server-sdk-dynamodb: 6.2.2</summary>

##
[6.2.2](node-server-sdk-dynamodb-v6.2.1...node-server-sdk-dynamodb-v6.2.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2
</details>

<details><summary>node-server-sdk-otel: 1.1.2</summary>

##
[1.1.2](node-server-sdk-otel-v1.1.1...node-server-sdk-otel-v1.1.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2
</details>

<details><summary>node-server-sdk-redis: 4.2.2</summary>

##
[4.2.2](node-server-sdk-redis-v4.2.1...node-server-sdk-redis-v4.2.2)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/node-server-sdk bumped from 9.7.1 to 9.7.2
  * peerDependencies
    * @launchdarkly/node-server-sdk bumped from >=9.4.3 to >=9.7.2
</details>

<details><summary>server-sdk-ai: 0.2.1</summary>

##
[0.2.1](server-sdk-ai-v0.2.0...server-sdk-ai-v0.2.1)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * devDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.9.0 to 2.10.0
  * peerDependencies
    * @launchdarkly/js-server-sdk-common bumped from 2.x to 2.10.0
</details>

<details><summary>vercel-server-sdk: 1.3.21</summary>

##
[1.3.21](vercel-server-sdk-v1.3.20...vercel-server-sdk-v1.3.21)
(2024-11-14)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * @launchdarkly/js-server-sdk-common-edge bumped from 2.5.1 to 2.5.2
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@kinyoklion
Copy link
Member

@ryanoglesby08

This is now released in @launchdarkly/akamai-server-edgekv-sdk (1.3.0).

Thank you,
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants