Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(world-module-erc20): export erc20 module from internal #3319

Merged
merged 8 commits into from
Oct 23, 2024

Conversation

vdrg
Copy link
Contributor

@vdrg vdrg commented Oct 22, 2024

No description provided.

@vdrg vdrg requested review from alvrs and holic as code owners October 22, 2024 18:01
Copy link

changeset-bot bot commented Oct 22, 2024

⚠️ No Changeset found

Latest commit: 9b6ad51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 25 packages
Name Type
@latticexyz/world-module-erc20 Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/cli Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/world Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic previously approved these changes Oct 22, 2024
@vdrg vdrg force-pushed the vdrg/erc20-module-internal branch from 067f4d2 to c303b42 Compare October 23, 2024 13:18
@vercel vercel bot temporarily deployed to Preview – explorer October 23, 2024 13:26 Inactive
@@ -11,3 +11,4 @@ export * from "../getFunctions";
export * from "../getWorldAbi";

export { resolveTableId, resolveWithContext } from "../config/v2/dynamicResolution";
export { ModuleInput } from "../config/v2/input";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw it's safe to just export * here since its internal

@holic holic merged commit 9080377 into main Oct 23, 2024
13 checks passed
@holic holic deleted the vdrg/erc20-module-internal branch October 23, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants