feat(world-module-erc20): new ERC20 World Module #3300
Conversation
🦋 Changeset detectedLatest commit: e44b98b The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
vdrg
changed the title
| if (!ResourceAccess.get(getNamespaceId(), sender)) { | ||
| revert CallerHasNoNamespaceAccess(); | ||
| } |
There was a problem hiding this comment.
could technically reuse the AccessControl library here:
mud/packages/world/src/AccessControl.sol
Lines 51 to 56 in 3a80bed
There was a problem hiding this comment.
but this would make it harder to see where the error comes from 🤔 I'm fine with either, which ever is more standard across the codebase
vdrg
changed the title
| function namespaceId() internal pure returns (ResourceId) { | ||
| return WorldResourceIdLib.encodeNamespace(NAMESPACE); | ||
| } | ||
|
|
||
| function registryTableId() internal pure returns (ResourceId) { | ||
| return WorldResourceIdLib.encode(RESOURCE_TABLE, NAMESPACE, REGISTRY_TABLE_NAME); | ||
| } |
There was a problem hiding this comment.
If these are only used during the installation leaving and not when interacting with the token it's fine to leave as is!
Co-authored-by: alvarius <[email protected]>
…s report depending on internal store vs world
| symbol: string; | ||
| }; | ||
|
|
||
| export function defineERC20Config({ namespace, name, symbol }: DefineERC20ConfigInput) { |
There was a problem hiding this comment.
how about defineERC20Module since it returns module input?
and can we specify the return type here so we know we're always getting config-compatible module input
export function defineERC20Module(...): Module
There was a problem hiding this comment.
we should save this file for doing the exports, not where the logic lives
so I would move this file to ts/defineERC20Module.ts then this file becomes
export { defineERC20Module } from "../defineERC20Module";
No description provided.