Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(explorer): update readme #3093

Merged
merged 19 commits into from
Aug 30, 2024
Merged

docs(explorer): update readme #3093

merged 19 commits into from
Aug 30, 2024

Conversation

karooolis
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6587f58

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

holic
holic reviewed Aug 29, 2024
View reviewed changes
packages/explorer/README.md Outdated Show resolved Hide resolved
@karooolis karooolis mentioned this pull request Aug 29, 2024
Merged
holic
holic reviewed Aug 29, 2024
View reviewed changes
packages/explorer/README.md Outdated Show resolved Hide resolved
@karooolis karooolis marked this pull request as draft August 29, 2024 16:19
@karooolis karooolis marked this pull request as ready for review August 29, 2024 16:41
@karooolis karooolis requested a review from holic August 29, 2024 16:43
holic
holic reviewed Aug 30, 2024
View reviewed changes
packages/explorer/README.md Outdated

2. **Start a local development chain**
- MUD project
- Development chain (e.g. Hardhat, Foundry)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a fairly strong coupling to foundry so not sure it's worth mentioning hardhat?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, changed to reference anvil specifically

holic
holic previously approved these changes Aug 30, 2024
View reviewed changes
@karooolis karooolis merged commit 5eb32a3 into main Aug 30, 2024
13 checks passed
@karooolis karooolis deleted the kumpis/update-explorer-readme branch August 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic left review comments

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karooolis @holic @qbzzt