feat: add changeset validation workflow #3067
Conversation
|
Co-authored-by: Kevin Ingersoll <[email protected]>
| name: Changeset | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Initially, thought to run workflow only if .changeset/** changes but then realized that package.json of packages may change too, causing changeset validation to fail. So now including all paths, although could still narrow down to .changeset/** and packages/**/package.json?
There was a problem hiding this comment.
sounds reasonable to run as-needed (just for changeset + package.json changes) although may also need to consider the pnpm-workspace.yaml (could change the scope what are considered workspace packages) and ~any package.json (e.g. **/package.json)
but also running it for every commit is fine too, should be lightweight enough to not matter much
There was a problem hiding this comment.
Perhaps then best to not restrict any paths since it is indeed lightweight, and don't want to miss anything accidentally.
| uses: ./.github/actions/setup | ||
|
|
||
| - name: Changeset | ||
| run: pnpm changeset status --since origin/main |
There was a problem hiding this comment.
Have to do it like this due to base branch set as main. Relevant issue: changesets/changesets#1055
No description provided.