feat(stash): add stash, the new MUD client state library #3040
Conversation
🦋 Changeset detectedLatest commit: 3a5e059 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/stash/src/actions/extend.ts
Outdated
| actions: actions; | ||
| }; | ||
|
|
||
| export type ExtendResult<stash extends Stash, actions> = stash & actions; |
There was a problem hiding this comment.
I guess the expectation/assumption here is there are no overlapping keys?
There was a problem hiding this comment.
yeah exactly (otherwise you'd get never on that key)
There was a problem hiding this comment.
you would?
looks like you get an intersection for each action
I wonder if we wanna use merge from arktype instead?
There was a problem hiding this comment.
Oh interesting, would have expected (() => void) & (() => number) to be collapsed to never since a function can't have both of those return types at the same time. Updated the type to be similar to merge from arktype by first omitting the existing keys and then combining with the extended keys (which is what already happened in js under the hood). That means it is now technically possible to override existing functions.
There was a problem hiding this comment.
(first used merge from arktype but then realized if we only use this one type it's pretty simple to just add it here instead of a dependency)
There was a problem hiding this comment.
That means it is now technically possible to override existing functions.
this was already happening at runtime, the types just better reflect it now
Co-authored-by: Kevin Ingersoll <[email protected]>
No description provided.