refactor(cli,world): move helper functions into world package, add getWorldAbi #3012
Conversation
|
packages/world/ts/getWorldDeploy.ts
Outdated
There was a problem hiding this comment.
do we need to move this? I don't think this is used by any helpers here
There was a problem hiding this comment.
It's needed because of how getWorldAbi is expecting the world deploy to be passed as one of the parameters https://github.com/latticexyz/mud/pull/2849/files#diff-c387c5680d2d7ed3fc8008e9769b2c37be5e4e2a0f11dda28f02521618047d1fR48-R53 . Subsequently, the world deploy param is used in getResourceIds({ client, worldDeploy }), getFunctions({ client, worldDeploy }), getResourceAccess({ client, worldDeploy }), getTableValue, and maybe some more.
There was a problem hiding this comment.
if we change the helper signatures to not be deployment specific and take in just what they need (i.e. world address, from/to block), we won't need this!
There was a problem hiding this comment.
Ah that's right, just removed the worldDeploy dependency everywhere, and updated getSystems params to be:
export async function getSystems({
client,
worldAddress,
stateBlock,
deployBlock,
}: {
readonly client: Client;
readonly worldAddress: Address;
readonly stateBlock: bigint;
readonly deployBlock: bigint;
}): Promise<readonly DeployedSystem[]> {
...There was a problem hiding this comment.
And updated all other helper functions to take in only the required params i.e. no more worldDeploy.
holic
changed the title
holic
changed the title
Great! Good idea, makes sense to add base ABI at this layer, just added. |
Co-authored-by: Kevin Ingersoll <[email protected]>
holic
changed the title
getWorldAbipulled out of #2849