fix(cli): fixed module artifactPath imports #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91b86a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
commented
May 15, 2024
| @@ -22,7 +21,7 @@ export const worldTables = configToTables(worldToV1(worldConfig)); | |||
|
|
|||
| export const worldDeployEvents = [helloStoreEvent, helloWorldEvent] as const; | |||
|
|
|||
| export const worldAbi = [...IBaseWorldAbi, ...IModuleAbi] as const; | |||
| export const worldAbi = IBaseWorldAbi; | |||
There was a problem hiding this comment.
the IBaseWorld ABI now includes the errors we wanted from IModule ABI
alvrs
previously approved these changes
May 15, 2024
holic
changed the title
holic
changed the title
alvrs
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have removed this in #2803 because we had already removed artifact imports there so we weren't using the dep anymore
this clears the path for using
mudCLI inside world-modules, which means we can split up the big, gnarly mud config there