Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve JsDoc on defineWorld output, bump @arktype/util #2815

Merged
merged 9 commits into from
Jul 11, 2024

Conversation

ssalbdivad
Copy link
Collaborator

@ssalbdivad ssalbdivad commented May 13, 2024

This preserves JSDoc annotations on defineWorld output using the new withJsDoc utility from @arktype/util per @holic's request.

It will preserve additional keys on the instantiated type, but will not preserve optionality on keys present on the JS Doc source type. Examples can be found here in the associated unit tests.

I also bumped @arktype/util and removed redundant locally defined utils. The only other change was evaluate was renamed to show, so I made that change wherever evaluate was referenced as well.

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: e9db3c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 23 packages
Name Type
@latticexyz/config Patch
@latticexyz/query Patch
@latticexyz/store Patch
@latticexyz/world Patch
@latticexyz/common Patch
@latticexyz/cli Patch
@latticexyz/protocol-parser Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
@latticexyz/dev-tools Patch
@latticexyz/react Patch
@latticexyz/store-indexer Patch
mock-game-contracts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/faucet Patch
@latticexyz/abi-ts Patch
create-mud Patch
@latticexyz/gas-report Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic merged commit 7129a16 into latticexyz:main Jul 11, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants