Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: up node memory during docker build #2810

Merged
merged 2 commits into from
May 14, 2024
Merged

build: up node memory during docker build #2810

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e3126
increasing node memory to be able to build the store-sync package (#2…
joergkiesewetter May 10, 2024
1c5ed43
adding build memory to the build command
joergkiesewetter May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ WORKDIR /app
# this resolves some chicken-and-egg problems with using workspace bins before they're created (install -> build -> install)
RUN pnpm recursive run prepare
RUN --mount=type=cache,id=pnpm,target=/pnpm/store pnpm install --frozen-lockfile
ENV NODE_OPTIONS=--max-old-space-size=4096
RUN pnpm run -r build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know ENV sticks around in the docker container? as in running the indexer would use 4gb memory too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.docker.com/reference/dockerfile/#env

The ENV instruction sets the environment variable to the value . This value will be in the environment for all subsequent instructions in the build stage and can be replaced inline in many as well.

sounds like just during build?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but also seeing

If an environment variable is only needed during build, and not in the final image, consider setting a value for a single command instead:

so I wonder if we use this instead:

RUN NODE_OPTIONS=--max-old-space-size=4096 pnpm run -r build


FROM mud AS store-indexer
Expand Down
Loading