feat(store,world): usable enum values from config #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 668b3d2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
changed the title
|
i very much like the new feature but is there any way we could turn this into a non-breaking change? maybe as a new property on the output? there might be teams out there using the current structure |
holic
commented
May 10, 2024
.changeset/sweet-lemons-eat.md
Outdated
| writeContract({ | ||
| // … | ||
| functionName: "setTerrainType", | ||
| args: [config.mappedEnums.TerrainType.Grass], |
There was a problem hiding this comment.
Suggested change
| args: [config.mappedEnums.TerrainType.Grass], | |
| args: [config.enumValues.TerrainType.Grass], |
I can't decide which 🤔
decided on enumValues
holic
changed the title
alvrs
reviewed
May 14, 2024
alvrs
previously approved these changes
May 14, 2024
Co-authored-by: alvarius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transforms enum input arrays into an object so they can be used in TS
closes #1957