Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(world): config uses readonly arrays #2805

Merged
merged 4 commits into from
May 8, 2024
Merged

fix(world): config uses readonly arrays #2805

merged 4 commits into from
May 8, 2024

Conversation

holic
Copy link
Member

@holic holic commented May 8, 2024

If you define a list of modules like

const modules = [...];

then later use them in your mud.config.ts, you'll get an error like this:

image

cc @0xhank

pulled out of #2803

Copy link

changeset-bot bot commented May 8, 2024

🦋 Changeset detected

Latest commit: 9ef8119

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/store-sync Patch
@latticexyz/world-modules Patch
mock-game-contracts Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/query Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
@latticexyz/services Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/store Patch
@latticexyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic marked this pull request as ready for review May 8, 2024 16:24
@holic holic requested review from alvrs and yonadaaa as code owners May 8, 2024 16:24
@holic holic merged commit 3dbf3bf into main May 8, 2024
12 checks passed
@holic holic deleted the holic/world-types branch May 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants