Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new config #2483

Merged
merged 17 commits into from
Mar 20, 2024
Merged

feat: use new config #2483

merged 17 commits into from
Mar 20, 2024

Conversation

holic
Copy link
Member

@holic holic commented Mar 20, 2024

taking another stab at #2470

Copy link

changeset-bot bot commented Mar 20, 2024

🦋 Changeset detected

Latest commit: 0d0bdb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@latticexyz/cli Major
@latticexyz/dev-tools Major
@latticexyz/store-sync Major
@latticexyz/store Major
@latticexyz/world-modules Major
@latticexyz/world Major
create-mud Major
@latticexyz/store-indexer Major
@latticexyz/query Major
@latticexyz/react Major
@latticexyz/abi-ts Major
@latticexyz/block-logs-stream Major
@latticexyz/common Major
@latticexyz/config Major
@latticexyz/ecs-browser Major
@latticexyz/faucet Major
@latticexyz/gas-report Major
@latticexyz/network Major
@latticexyz/noise Major
@latticexyz/phaserx Major
@latticexyz/protocol-parser Major
@latticexyz/recs Major
@latticexyz/schema-type Major
@latticexyz/services Major
@latticexyz/solecs Major
solhint-config-mud Major
solhint-plugin-mud Major
@latticexyz/std-client Major
@latticexyz/std-contracts Major
@latticexyz/store-cache Major
@latticexyz/utils Major
mock-game-contracts Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't used, was moved up a directory but this never got removed

createdAt: "uint256",
completedAt: "uint256",
description: "string",
},
key: ["id"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOC it is possible to use shorthand here?

Or alternatively you could reduce the diff by keeping the key name

Comment on lines +6 to +12
schema: {
id: "bytes32",
createdAt: "uint256",
completedAt: "uint256",
description: "string",
},
key: ["id"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
schema: {
id: "bytes32",
createdAt: "uint256",
completedAt: "uint256",
description: "string",
},
key: ["id"],
id: "bytes32",
createdAt: "uint256",
completedAt: "uint256",
description: "string",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking at all though

@alvrs alvrs merged commit 252a185 into main Mar 20, 2024
11 checks passed
@alvrs alvrs deleted the holic/use-new-config-2 branch March 20, 2024 19:16
@holic holic mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants