-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(templates/threejs): easier to use template #2473
Conversation
|
<meshStandardMaterial color="green" /> | ||
</mesh> | ||
<mesh position={[0, -1, 0]}> | ||
{/* eslint-disable-next-line react/no-unknown-property */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we figure out how to get react+eslint to allow this? I assume there's a three.js eslint config to include here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the solution I found online doesn't work. Can we please just not worry about it? Prettier here is more trouble than it is worth, IMAO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like an open issue and the @react-three/eslint-plugin didn't work for me.
For now I added a comment at the top of the file but we could also add a eslintrc
rule like
ts"react/no-unknown-property": ["off", { "ignore": ["JSX"] }],
@yonadaaa need a changeset for "create-mud" to make sure this goes out with next release |
Closing: #2469