feat(templates/threejs): easier to use template #2473
Conversation
|
| <meshStandardMaterial color="green" /> | ||
| </mesh> | ||
| <mesh position={[0, -1, 0]}> | ||
| {/* eslint-disable-next-line react/no-unknown-property */} |
There was a problem hiding this comment.
can we figure out how to get react+eslint to allow this? I assume there's a three.js eslint config to include here
There was a problem hiding this comment.
And the solution I found online doesn't work. Can we please just not worry about it? Prettier here is more trouble than it is worth, IMAO.
There was a problem hiding this comment.
I've always run into this issue with ThreeJS and TypeScript, I'll play around and try fix it. Also I get errors for all the elements so we are going to need a lot of these comments otherwise!
There was a problem hiding this comment.
Sounds like an open issue and the @react-three/eslint-plugin didn't work for me.
For now I added a comment at the top of the file but we could also add a eslintrc rule like
ts"react/no-unknown-property": ["off", { "ignore": ["JSX"] }],
|
Tweaked the topbar colors: |
|
@yonadaaa need a changeset for "create-mud" to make sure this goes out with next release |
Closing: #2469