Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run prepare before install in Dockerfile #2376

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

holic
Copy link
Member

@holic holic commented Mar 5, 2024

had this fix/workaround in CI but not in Dockerfile

Copy link

changeset-bot bot commented Mar 5, 2024

⚠️ No Changeset found

Latest commit: 80faacd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@holic
Copy link
Member Author

holic commented Mar 5, 2024

confirmed that this got past the install/build step:
https://github.com/latticexyz/mud/actions/runs/8160408709/job/22306926234

merging to fix main's docker release step

@holic holic merged commit c60aa8b into main Mar 5, 2024
15 checks passed
@holic holic deleted the holic/fix-dockerfile-prepare branch March 5, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant