Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test workflow runs with ubuntu and windows OS #2340

Closed
wants to merge 8 commits into from

Conversation

yonadaaa
Copy link
Contributor

Fixes #2197

Copy link

changeset-bot bot commented Feb 28, 2024

⚠️ No Changeset found

Latest commit: 7c136fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@yonadaaa yonadaaa changed the title chore: test runner uses matrix of ubuntu and windows chore: test workflow uses ubuntu and windows OS Feb 28, 2024
@yonadaaa yonadaaa changed the title chore: test workflow uses ubuntu and windows OS chore: test workflow runs with ubuntu and windows OS Feb 28, 2024
@yonadaaa
Copy link
Contributor Author

Running with windows-latest is failing:

https://github.com/latticexyz/mud/actions/runs/8082956911/job/22084918032?pr=2340

This is because we use a container for Postgres. Containers are not supported:

actions/runner#904 (comment)

@yonadaaa
Copy link
Contributor Author

yonadaaa commented Feb 28, 2024

The OS matrix works as expected, but running it exposed some issues that the MUD monorepo has with Windows:

@holic
Copy link
Member

holic commented Aug 28, 2024

replaced by #3078

@holic holic closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add windows OS to CI runners
2 participants