fix: add test case for an array function argument

latticexyz · Dec 20, 2024 · 6aaed39 · 6aaed39
1 parent 6d4cbec
commit 6aaed39
Show file tree

Hide file tree

Showing 9 changed files with 477 additions and 4 deletions.
diff --git a/packages/world/ts/node/render-solidity/renderSystemLibrary.ts b/packages/world/ts/node/render-solidity/renderSystemLibrary.ts
@@ -263,7 +263,10 @@ function renderFunctionInterface(contractFunction: ContractInterfaceFunction) {
 
 function functionInterfaceName(contractFunction: ContractInterfaceFunction) {
   const { name, parameters } = contractFunction;
-  const paramTypes = parameters.map((param) => param.split(" ")[0]).join("_");
+  const paramTypes = parameters
+    .map((param) => param.split(" ")[0])
+    .map((type) => type.replace("[]", "Array"))
+    .join("_");
   return `_I${name}${paramTypes.length === 0 ? "" : `_${paramTypes}`}`;
 }
 

diff --git a/test/system-libraries/mud.config.ts b/test/system-libraries/mud.config.ts
@@ -16,6 +16,14 @@ export default defineWorld({
           },
           key: [],
         },
+        PositionValue: {
+          schema: {
+            x: "uint256",
+            y: "uint256",
+            z: "uint256",
+          },
+          key: [],
+        },
       },
     },
     b: {},

diff --git a/test/system-libraries/src/codegen/world/IASystem.sol b/test/system-libraries/src/codegen/world/IASystem.sol
diff --git a/test/system-libraries/src/namespaces/a/ASystem.sol b/test/system-libraries/src/namespaces/a/ASystem.sol
@@ -3,8 +3,9 @@ pragma solidity >=0.8.28;
 
 import { System } from "@latticexyz/world/src/System.sol";
 import { Value } from "./codegen/tables/Value.sol";
+import { PositionValue } from "./codegen/tables/PositionValue.sol";
 import { AddressValue } from "./codegen/tables/AddressValue.sol";
-import { ASystemThing } from "./ASystemTypes.sol";
+import { ASystemThing, Position } from "./ASystemTypes.sol";
 
 contract ASystem is System {
   function setValue(ASystemThing memory value) external {
@@ -15,6 +16,20 @@ contract ASystem is System {
     Value.set(value);
   }
 
+  function setPosition(Position memory position) external {
+    PositionValue.set(position.x, position.y, position.z);
+  }
+
+  function setPosition(uint256 x, uint256 y, uint256 z) external {
+    PositionValue.set(x, y, z);
+  }
+
+  function setPositions(Position[] memory positions) external {
+    for (uint256 i = 0; i < positions.length; i++) {
+      PositionValue.set(positions[i].x, positions[i].y, positions[i].z);
+    }
+  }
+
   function getValue() external view returns (uint256) {
     return Value.get();
   }

diff --git a/test/system-libraries/src/namespaces/a/ASystemTypes.sol b/test/system-libraries/src/namespaces/a/ASystemTypes.sol
@@ -4,3 +4,9 @@ pragma solidity >=0.8.28;
 struct ASystemThing {
   uint256 a;
 }
+
+struct Position {
+  uint256 x;
+  uint256 y;
+  uint256 z;
+}
diff --git a/test/system-libraries/src/namespaces/a/codegen/index.sol b/test/system-libraries/src/namespaces/a/codegen/index.sol
diff --git a/test/system-libraries/src/namespaces/a/codegen/systems/ASystemLib.sol b/test/system-libraries/src/namespaces/a/codegen/systems/ASystemLib.sol