Feature/597 docs and images in playground params #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neoxelox
force-pushed
the
feature/597-docs-and-images-in-playground-params
branch
from
2f02ab6 to
3eb9636
Compare
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
...s/[documentUuid]/_components/DocumentEditor/Editor/Playground/DocumentParams/Input/index.tsx
Outdated
Show resolved
Hide resolved
geclos
reviewed
Dec 13, 2024
...mitUuid]/documents/[documentUuid]/logs/_components/DocumentLogs/DocumentLogInfo/Metadata.tsx
Show resolved
Hide resolved
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
reviewed
Dec 13, 2024
geclos
previously approved these changes
Dec 13, 2024
There was a problem hiding this comment.
lovely work only note would be to try to split PRs in smaller chunks for the future. An example split would be:
- A PR implementing the server actions/services
- A PR implementing the frontend plumbing
I know I have a 14k monster PR pending but that was a failure on my side.
neoxelox
force-pushed
the
feature/597-docs-and-images-in-playground-params
branch
from
65027a4 to
4599fc4
Compare
neoxelox
deleted the
feature/597-docs-and-images-in-playground-params
branch
| @@ -113,6 +119,7 @@ export function useDocumentParameters({ | |||
| documentVersionUuid: string | |||
| commitVersionUuid: string | |||
| }) { | |||
| // TODO: Delete stale inputs as new inputs could eventually not fit | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #597