feature: update workspace name #63
Conversation
geclos
force-pushed
the
feature/provider_apikeys
branch
from
33998e3 to
11ebfec
Compare
Implements first version of settings page with workspace name update
geclos
force-pushed
the
feature/provider_apikeys
branch
from
11ebfec to
2cc5f52
Compare
|
🐮 👦🏼 |
| trailing: true, | ||
| }) | ||
|
|
||
| // TODO: i18n |
There was a problem hiding this comment.
it adds little friction and adding i18n later is a massive pita
There was a problem hiding this comment.
But this is an app for people who are prompting in English. Why would it need to be translated into other languages?
Adding i18n is always a pita. Less now than later but still maintaining translations is a burden that we might avoid in this app. My 2 cents
|
|
||
| // TODO: i18n | ||
| return ( | ||
| <div className='flex flex-col gap-4 max-w-[50%]'> |
There was a problem hiding this comment.
A simple form like this is easier with normal forms + revalidatePath. You could remove a lot of the code done here
There was a problem hiding this comment.
No necessary to debounce because you don't manage input value. You let uncontrolled and on form submit action goes to the server like a plain old rails app
Implements first version of settings page with workspace name update