Document Editor page #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...ojectId]/versions/[commitUuid]/documents/[documentUuid]/_components/DocumentEditor/index.tsx
Outdated
Show resolved
Hide resolved
...app/(private)/projects/[projectId]/versions/[commitUuid]/documents/[documentUuid]/layout.tsx
Outdated
Show resolved
Hide resolved
csansoon
force-pushed
the
document-editor
branch
4 times, most recently
from
552ac7d to
9339d63
Compare
csansoon
commented
Jul 23, 2024
Comment on lines
26
to
38
| // When imported, Monaco automatically tries to use the window object. | ||
| // Since this is not available when rendering on the server, we only | ||
| // render the fallback component for SSR. | ||
| if (typeof window === 'undefined') return <DocumentTextEditorFallback /> | ||
| const [isClient, setIsClient] = useState(false) | ||
|
|
||
| useEffect(() => { | ||
| setIsClient(typeof window !== 'undefined') | ||
| }, []) | ||
|
|
||
| if (!isClient) { | ||
| return <DocumentTextEditorFallback /> | ||
| } | ||
| return <DocumentTextEditor {...props} /> |
There was a problem hiding this comment.
This fixes the "hydration" error that Next.js shows when loading the editor, because it rendered something different in SSR and in the browser. Now, both render the fallback at first and then the browser updates to the actual editor (which renders the fallback too until monaco fully loads anyways)
csansoon
force-pushed
the
document-editor
branch
7 times, most recently
from
47cefff to
f8c081f
Compare
| const document = documents.find((d) => d.path === path) | ||
| if (!document) { | ||
| throw new NotFoundError('Document not found') | ||
| } |
There was a problem hiding this comment.
This should be a core method. originalGetDocumentByPath
|
|
||
| const documentContent = documentsByPath[path] | ||
| if (documentContent === undefined) { | ||
| throw new Error('Document not found') |
There was a problem hiding this comment.
Who handles this error?
| onMount={handleEditorDidMount} | ||
| onChange={handleValueChange} | ||
| options={{ | ||
| fixedOverflowWidgets: true, |
There was a problem hiding this comment.
So much pain in this boolean 😂
andresgutgon
previously approved these changes
Jul 24, 2024
Base automatically changed from
recompute-all-draft-changes-when-updating-any-document
to
main
July 24, 2024 09:02
csansoon
force-pushed
the
document-editor
branch
from
f8c081f to
b8fcc87
Compare
csansoon
force-pushed
the
document-editor
branch
from
b8fcc87 to
61ba4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration of the document editor page. Clicking on a document from the sidebar shows the editor, which can be used to edit documents from draft commits.
Screen.Recording.2024-07-23.at.17.04.59.mov