Fix open folders in sidebar #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/sidebar-file-actions-popover
branch
from
561e0ac to
bc3a363
Compare
The old approach did not work because navigating to a new document would re-render the tree. We now try to hold that state in Zustand so it can be persisted across navigations
andresgutgon
force-pushed
the
feature/sidebar-file-actions-popover
branch
from
bc3a363 to
9082de5
Compare
csansoon
reviewed
Jul 23, 2024
Comment on lines
+21
to
+31
| it('shout remove nested paths', async () => { | ||
| const { result } = renderHook(() => useOpenPaths((state) => state)) | ||
| act(() => { | ||
| result.current.togglePath('some-folder/nested-folder/doc1') | ||
| }) | ||
|
|
||
| act(() => { | ||
| result.current.togglePath('some-folder/nested-folder') | ||
| }) | ||
| expect(result.current.openPaths).toEqual(['', 'some-folder']) | ||
| }) |
csansoon
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The old approach did not work because navigating to a new document would re-render the tree. We now try to hold that state in Zustand so it can persist across navigations