refactor(core): simplify document log queries by removing baseQuery #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor simplifies the logic for querying document logs with metadata and errors by removing the `baseQuery` intermediate step and instead using a repository. This commit also fixes a bug where the document log was getting fetched from a paginated query which could occasionally result in false not found errors. - Updated `computeDocumentLogsWithMetadataQuery` to return the repository scope directly. - Refactored related test files to align with the new query structure. - Removed redundant code and imports related to the old `baseQuery` approach. - Ensured all tests pass with the new query structure. This change improves code readability and maintainability by reducing unnecessary complexity in the query logic.
geclos
force-pushed
the
fix/compute_document_logs_query
branch
from
d4cb65f to
bc9a58a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor simplifies the logic for querying document logs with metadata and errors by removing the
baseQueryintermediate step and instead using a repository. This commit also fixes a bug where the document log was getting fetched from a paginated query which could occasionally result in false not found errors.computeDocumentLogsWithMetadataQueryto return the repository scope directly.baseQueryapproach.This change improves code readability and maintainability by reducing unnecessary complexity in the query logic.