Simpler evaluations part 1.3 #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
previously approved these changes
Oct 28, 2024
csansoon
force-pushed
the
simpler_evaluations_part_1.3
branch
2 times, most recently
from
5c3321b to
b89c5c6
Compare
csansoon
force-pushed
the
simpler_evaluations_part_1.3
branch
from
b89c5c6 to
205a627
Compare
csansoon
force-pushed
the
simpler_evaluations_part_1.3
branch
from
205a627 to
c8d0d36
Compare
csansoon
commented
Oct 29, 2024
Comment on lines
+1
to
+11
| --- Migrate configuration column from "evaluations" to "llm_as_judge_evaluation_metadatas" | ||
| UPDATE "latitude"."llm_as_judge_evaluation_metadatas" | ||
| SET "configuration" = "latitude"."evaluations"."configuration" | ||
| FROM "latitude"."evaluations" | ||
| WHERE "latitude"."evaluations"."metadata_id" = "latitude"."llm_as_judge_evaluation_metadatas"."id";--> statement-breakpoint | ||
|
|
||
| --- Remove evaluation metadatas with NULL configuratios (these are llm_as_judge_evaluation_metadatas rows that were left when removing the original evaluation) | ||
| DELETE FROM "latitude"."llm_as_judge_evaluation_metadatas" WHERE "latitude"."llm_as_judge_evaluation_metadatas"."configuration" IS NULL--> statement-breakpoint | ||
|
|
||
| --- Set configuration column as NOT NULL | ||
| ALTER TABLE "latitude"."llm_as_judge_evaluation_metadatas" ALTER COLUMN "configuration" SET NOT NULL; |
There was a problem hiding this comment.
Moving configuration from evaluations to llm_as_judge_evaluation_metadatas, and then removing the llm_as_judge_evaluation_metadatas that were left over after removing their original evaluations
geclos
reviewed
Oct 29, 2024
| @@ -58,7 +58,7 @@ export type LlmAsJudgeEvaluationMetadata = InferSelectModel< | |||
| export type Subscription = InferSelectModel<typeof subscriptions> | |||
|
|
|||
| export type EvaluationDto = Evaluation & { | |||
| configuration?: LlmAsJudgeEvaluationMetadata['configuration'] | |||
| configuration: LlmAsJudgeEvaluationMetadata['configuration'] | null | |||
There was a problem hiding this comment.
why the null? isn't it supposed to be not null after your migration ☝🏼 ?
There was a problem hiding this comment.
This is the original configuration attribute from the evaluations, not the new one in the LegacyMetadata, so technically every value should be Null here now. This is just for compatibility while I'm doing changes and will be removed in the future.
geclos
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1.3
Perform the migration to move all configuration data from evaluations to evaluationMetadataLlmAsJudgeLegacy.