chore: fix performance of evaluation results table #3 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geclos
force-pushed
the
feature/remove_total_count_from_eval_results
branch
from
105f37a to
4c57e1b
Compare
The total count is just too much for the db. We have to remove it and resort to dumber pagination in favour of better performance.
geclos
force-pushed
the
feature/remove_total_count_from_eval_results
branch
from
4c57e1b to
0f194bc
Compare
|
|
||
| return Result.ok(rows) | ||
| } | ||
|
|
||
| export async function computeEvaluationResultsByDocumentContentCount( |
There was a problem hiding this comment.
Should we also remove from logs?
There was a problem hiding this comment.
hmm not really if it's just a count of document logs filtered by documentuuid and commit it should be fast, what's hurting this particular count is the multiples inner joins required
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The total count is just too much for the db. We have to remove it and resort to dumber pagination in favour of better performance.