Improve document logs table perfomance #472
Conversation
|
|
||
| import { Commit } from '../../browser' | ||
| import { database } from '../../client' | ||
| import { | ||
| createDocumentLogQuery, | ||
| getCommitFilter, | ||
| } from './_createDocumentLogQuery' |
There was a problem hiding this comment.
I 🔥 this archive. Now all the "with metadata" things are in this file. I left a FIXME in evaluations to do the same
| }) { | ||
| const byDocumentUuid = documentUuid | ||
| ? eq(scope.documentUuid, documentUuid) | ||
| : sql`1 = 1` |
There was a problem hiding this comment.
If documentUuid is not passed we don't care and use 1 = 1. This case is covering /evaluations playground where we get a documentLog.resolvedContent for the evaluation variables
We don't have the scope of documentUuid
There was a problem hiding this comment.
hmm don't get it is this gonna match all document logs a pelo? in what scenario do we care about document logs without filtering by document uuid
There was a problem hiding this comment.
In the playground we can import any document log from any project and any document
There was a problem hiding this comment.
| const documentLogUuid = uuid() | ||
| let providerLogs: ProviderLog[] = [] | ||
|
|
||
| if (!skipProviderLogs) { |
There was a problem hiding this comment.
Make provider logs creation optional on this factory
andresgutgon
force-pushed
the
fix/document-logs-query-pagination
branch
from
00a51ab to
22655ba
Compare
Doing something similar to what we did with evaluation results where we filter by page and object the rows to be shown in the aggregated table of logs. This should improve performance
andresgutgon
force-pushed
the
fix/document-logs-query-pagination
branch
from
22655ba to
c6a5943
Compare
| export async function computeDocumentLogsWithMetadataCount( | ||
| { | ||
| workspaceId, | ||
| documentUuid, | ||
| draft, | ||
| }: { | ||
| workspaceId: number | ||
| documentUuid: string | ||
| draft?: Commit | ||
| }, | ||
| db = database, | ||
| ) { | ||
| const { scope } = getRepositoryScopes(workspaceId, db) | ||
|
|
||
| const countList = await db | ||
| .select({ | ||
| count: sql<number>`count(*)`.as('total_count'), | ||
| }) | ||
| .from(scope) | ||
| .innerJoin(commits, eq(commits.id, scope.commitId)) | ||
| .where(getCommonQueryConditions({ scope, documentUuid, draft })) | ||
|
|
||
| return countList?.[0]?.count ? Number(countList[0].count) : 0 | ||
| } |
There was a problem hiding this comment.
This is not "with metadata", could easily be moved to DocumentLogsRepository. Although I get that you want to keep the getCommonQueryConditions
What?
Doing something similar to what we did with evaluation results, we filter by page and object the rows to be shown in the aggregated table of logs. This should improve performance
TODO