Soft delete support #471
Merged
Soft delete support #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csansoon
force-pushed
the
soft-delete
branch
4 times, most recently
from
94a576f to
803fa61
Compare
csansoon
commented
Oct 21, 2024
Comment on lines
-28
to
+39
| return evaluations.map((p) => ({ | ||
| label: p.name, | ||
| href: segments[1] | ||
| ? ROUTES.evaluations.detail({ uuid: p.uuid })[ | ||
| segments[1] as EvaluationRoutes | ||
| ].root | ||
| : ROUTES.evaluations.detail({ uuid: p.uuid }).root, | ||
| })) | ||
| return evaluations.map((p) => { | ||
| const baseRoute = ROUTES.evaluations.detail({ uuid: p.uuid }) | ||
| const href = evaluationSegment | ||
| ? (baseRoute[evaluationSegment]?.root ?? baseRoute.root) | ||
| : baseRoute.root | ||
|
|
||
| return { | ||
| label: p.name, | ||
| href, | ||
| } | ||
| }) |
There was a problem hiding this comment.
Fixed a bug where the Breadcrumb component failed on /evaluations/<uuid>/destroy
|
@andresgutgon That's tested in the |
csansoon
force-pushed
the
soft-delete
branch
4 times, most recently
from
1a52deb to
2946165
Compare
geclos
reviewed
Oct 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is about 300-400 LOC, not over 3k... You know the deal with Drizzle.
Added soft delete on drafts, evaluations and providerApiKeys. Soft-deleted rows, or data related to soft-deleted rows (like document logs from removed commits, or evaluation results from removed evaluations) will not be available from the respective repositories. Deleted logs and results are taken into account when calculating workspace usage though.
Additionally, "deleting" a
providerApiKeywill censor the token forever. This means that data can still be aggregated with this provider, it cannot be used to generate new logs.