Change sidebar tree creation to use path instead of parentId. Also move sidebar to web-ui #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/prettify-sidebar
branch
2 times, most recently
from
68dc0f8 to
ea7ba6f
Compare
geclos
reviewed
Jul 19, 2024
geclos
reviewed
Jul 19, 2024
| isRoot = false, | ||
| name = '', | ||
| }: { | ||
| id: string |
There was a problem hiding this comment.
what is this id? do we need it?
There was a problem hiding this comment.
for key react elements in the dom tree. Is nice to do key={node.id}
andresgutgon
force-pushed
the
feature/prettify-sidebar
branch
from
ea7ba6f to
917de40
Compare
andresgutgon
commented
Jul 19, 2024
| // We pre-sorted documents by path depth, so we know | ||
| // that the parent node exists | ||
| const parent = nodeMap.get(parentPath)! | ||
| parent.children.push(node) |
There was a problem hiding this comment.
Before pushing the node find their place alphabetically. if it's a folder goes first.
There was a problem hiding this comment.
I'll do this in another PR Carlos wants this code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We decided to start using document.path as source of truth. We need to change sidebar tree creation