Apply new progress evaluation bar design #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
commented
Oct 18, 2024
| @@ -179,6 +179,39 @@ describe('runEvaluationJob', () => { | |||
| }) | |||
| }) | |||
|
|
|||
| it('increment error counter when response has an error', async () => { | |||
There was a problem hiding this comment.
We were missing updating the counter of errors on an evaluation when the error happens in the response. We were checking only the result of the run.
Errors can happen:
- Before
runChainoccours. Errors onrunEvaluation - Errors on
runChainwhich are inside therun.response
andresgutgon
force-pushed
the
feature/new-progress-evaluation-bar
branch
from
419d5a9 to
8a0f3ce
Compare
11 tasks
geclos
previously approved these changes
Oct 18, 2024
andresgutgon
force-pushed
the
feature/save-errors-when-a-chain-run
branch
from
a6f3d97 to
cd9c5f4
Compare
andresgutgon
force-pushed
the
feature/new-progress-evaluation-bar
branch
from
8a0f3ce to
36fb537
Compare
We unify in a unique line completed and errored evaluation counters
andresgutgon
force-pushed
the
feature/new-progress-evaluation-bar
branch
from
36fb537 to
cfdbfbb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
TODO
useFetcherin here