Current commit management #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geclos
reviewed
Jul 16, 2024
geclos
reviewed
Jul 16, 2024
geclos
reviewed
Jul 16, 2024
geclos
reviewed
Jul 16, 2024
csansoon
force-pushed
the
current-commit
branch
10 times, most recently
from
08fcb09 to
4eaf332
Compare
csansoon
force-pushed
the
current-commit
branch
2 times, most recently
from
51b0d3f to
a13cb2a
Compare
Thinking about this we could store it in a cookie so the selection of the commit happens on the server |
| .orderBy(desc(commits.mergedAt)) | ||
| .limit(1) | ||
|
|
||
| if (!result.length) |
There was a problem hiding this comment.
Use {} for the ifs when are more than one line please
There was a problem hiding this comment.
They were originally one-liners but prettier apparently didn't like it 😭
| .select({ mergedAt: commits.mergedAt }) | ||
| .from(commits) | ||
| .where(eq(commits.uuid, commitUuid)) | ||
| .limit(1) |
There was a problem hiding this comment.
For the findOne, it is better to use findFirst. You don't need to do the limit(1)[0] thing.
I believe something like this works:
tx.query.commits.findFirst({
with: { mergedAt: true },
where: eq(commits.uuid, commitUuid)
})| projectCommitOrderIdx: index('project_commit_order_idx').on( | ||
| table.mergedAt, | ||
| table.projectId, | ||
| ), |
There was a problem hiding this comment.
Does this change the schema?
csansoon
force-pushed
the
current-commit
branch
5 times, most recently
from
bed25b5 to
32eaec1
Compare
|
☝️ Redistributed as multiple different PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the user will be able to select which commit to load into the app. This will let them not only watch older versions of the project, but also create new draft commits and work on them, while other users can simultaneously work on their own drafts.
This requires some changes on the code.
commitContextto store in the app's localStorage the current selected commit. Only draft commits are editable, so anotherisEditableproperty is also exposed.TODO
The currently selected commit should be scoped by project, not the whole client.