App layout with top header #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/app-layout
branch
from
d2669fd to
0d9bf75
Compare
andresgutgon
commented
Jul 17, 2024
| "react": "19.x", | ||
| "react-dom": "19.x", | ||
| "eslint": "8.x", | ||
| "eslint": "9.x" |
There was a problem hiding this comment.
No pnpm warnings for miss match versions
csansoon
reviewed
Jul 18, 2024
andresgutgon
force-pushed
the
feature/app-layout
branch
2 times, most recently
from
b510b7c to
23808da
Compare
csansoon
previously approved these changes
Jul 18, 2024
andresgutgon
force-pushed
the
feature/app-layout
branch
from
23808da to
b2abde4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Setup app layout and project model
TODO
/projects->/projects/:first_project/projects/:id/commits->/projects/:id/commits/:first_commit