Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: better evaluation editor #308

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

geclos
Copy link
Collaborator

@geclos geclos commented Sep 29, 2024

Instead of a random list of inputs we display a collapsible box with the contents of the provider log.

@geclos geclos force-pushed the feature/better_evaluation_editor branch 2 times, most recently from aa75140 to 4808fd0 Compare September 29, 2024 21:17
@geclos geclos force-pushed the feature/context_is_no_longer_a_json branch 2 times, most recently from c5b0aa8 to 5b97934 Compare September 30, 2024 07:47
Base automatically changed from feature/context_is_no_longer_a_json to main September 30, 2024 07:48
@geclos geclos force-pushed the feature/better_evaluation_editor branch 2 times, most recently from c3fb554 to e6b94ed Compare September 30, 2024 12:07
@@ -0,0 +1,16 @@
import { Button, Icon, toast } from '@latitude-data/web-ui'

export const CopyButton = ({ text }: { text: string }) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a molecule. Is fully generic

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a ClickToCopy molecule that is just that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will consolidate in a future PR

andresgutgon
andresgutgon previously approved these changes Sep 30, 2024
csansoon
csansoon previously approved these changes Sep 30, 2024
@geclos geclos dismissed stale reviews from csansoon and andresgutgon via d5d4495 September 30, 2024 12:18
@geclos geclos force-pushed the feature/better_evaluation_editor branch from e6b94ed to d5d4495 Compare September 30, 2024 12:18
Instead of a random list of inputs we display a collapsible box with the
contents of the provider log.
@geclos geclos force-pushed the feature/better_evaluation_editor branch from d5d4495 to 9ed0f14 Compare September 30, 2024 12:21
@geclos geclos merged commit 6ff3b4d into main Sep 30, 2024
4 checks passed
@geclos geclos deleted the feature/better_evaluation_editor branch September 30, 2024 12:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants