Decouple evaluation logs from aggregations #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresgutgon
force-pushed
the
feature/decouple-evaluation-logs-from-aggregations
branch
from
8160dff to
caf8ca7
Compare
andresgutgon
commented
Sep 19, 2024
| and( | ||
| eq(evaluationResultsScope.evaluationId, evaluation.id), | ||
| eq(documentLogsScope.documentUuid, documentUuid), | ||
| getCommitFilter(commit), |
There was a problem hiding this comment.
Implement filtering by all the versions of the documents since it was changed until the version of the document is in the current commit in the screen.
I need to talk more offline about this. Not really sure.
I think this way keeps current behaviour
andresgutgon
force-pushed
the
feature/decouple-evaluation-logs-from-aggregations
branch
2 times, most recently
from
9d65427 to
94a0ae7
Compare
andresgutgon
force-pushed
the
feature/decouple-evaluation-logs-from-aggregations
branch
4 times, most recently
from
3f7178c to
d714839
Compare
geclos
reviewed
Sep 20, 2024
| { | ||
| fallbackData: serverData, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
add the interval refetch every x seconds please, we need it until we implement realtime streaming of logs
There was a problem hiding this comment.
We can manually refetch with websockets, right?
There was a problem hiding this comment.
ah you mean from actual real logs, not only from batches
There was a problem hiding this comment.
we can do it from websockets but until that is implemented i don't want to break the realtime feeling of this section
geclos
reviewed
Sep 20, 2024
...aluations/[evaluationId]/_components/MetricsSummary/BigNumberPanels/MeanValuePanel/index.tsx
Outdated
Show resolved
Hide resolved
geclos
reviewed
Sep 20, 2024
| refreshInterval: 0, | ||
| fallbackData: modal, | ||
| }, | ||
| ) |
geclos
reviewed
Sep 20, 2024
| </Text.H4M> | ||
| </div> | ||
| ), | ||
| }, |
geclos
reviewed
Sep 20, 2024
packages/core/src/services/evaluationResults/aggregations/modalValueQuery.ts
Outdated
Show resolved
Hide resolved
csansoon
reviewed
Sep 20, 2024
...tUuid]/evaluations/[evaluationId]/_components/MetricsSummary/BigNumberPanels/Panel/index.tsx
Show resolved
Hide resolved
csansoon
reviewed
Sep 20, 2024
...evaluations/[evaluationId]/_components/MetricsSummary/BigNumberPanels/TotalsPanels/index.tsx
Outdated
Show resolved
Hide resolved
csansoon
previously approved these changes
Sep 20, 2024
andresgutgon
force-pushed
the
feature/decouple-evaluation-logs-from-aggregations
branch
2 times, most recently
from
f34996c to
b72bab7
Compare
andresgutgon
force-pushed
the
feature/decouple-evaluation-logs-from-aggregations
branch
from
b72bab7 to
f35f84a
Compare
andresgutgon
deleted the
feature/decouple-evaluation-logs-from-aggregations
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of this issue #205 this PR decouples big numbers aggregation from logs query so we can paginate (maybe) the logs query.
TODO
1000to evaluation results table now that's decouple from stats.Next PR
Fancy logs selection by document version for
meanQueryandmodalQuery